Forkpty replace#21
Open
RoniKishner wants to merge 1 commit into
Open
Conversation
Owner
Author
|
/split-pr |
|
Split complete. Open these pull requests:
|
|
/split-pr |
1 similar comment
|
/split-pr |
|
Split complete. Open these pull requests:
|
This was referenced Jun 22, 2026
Owner
Author
|
/split-pr |
|
To open the split PRs under your GitHub account (so you can edit and close them), please authorize the app. Once authorized, the split will run automatically. The link expires in 1 hour; comment |
Owner
Author
|
/split-pr |
|
You need to wait 5 minutes before calling |
This was referenced Jun 27, 2026
|
Split complete. Open these pull requests:
|
a5dde78 to
a0ccc75
Compare
Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: rkishner <rkishner@redhat.com>
a0ccc75 to
0c9c757
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
replace pexpect.spawn with pty+subprocess to avoid forkpty
Which issue(s) this PR fixes:
DeprecationWarning on
test_vm_consoleSpecial notes for reviewer:
The following warning was shown:
/tmp/pr-tests/.local/share/uv/python/cpython-3.14.5-linux-x86_64-gnu/lib/python3.14/pty.py:66: DeprecationWarning: This process (pid=110) is multi-threaded, use of forkpty() may lead to deadlocks in the child.jira-ticket:
NONE