Skip to content

[split] Main changes — from #21#32

Closed
RoniKishner wants to merge 1 commit into
mainfrom
split-pr-21-1782579575-main
Closed

[split] Main changes — from #21#32
RoniKishner wants to merge 1 commit into
mainfrom
split-pr-21-1782579575-main

Conversation

@RoniKishner

Copy link
Copy Markdown
Owner

Automated split from #21.

Context

This is the main / behavior half of an automated split from #21.

Changes in this PR:

  • utilities/console.py: Added imports for pty, shlex, subprocess, and pexpect.fdpexpect
  • Modified init to include _proc attribute for subprocess handle and updated self.child type hint
  • Modified connect() to call _terminate_proc on error for clean subprocess shutdown
  • Modified disconnect() to check subprocess status via _proc.poll() and ensure _terminate_proc is called
  • Added _spawn_console() function to create PTY and run virtctl via subprocess, replacing pexpect.spawn
  • Added _terminate_proc() function to gracefully and forcefully shut down the console subprocess
  • Updated console_eof_sampler() to use _spawn_console() internally and removed obsolete parameters
How this split maps your changes
  • Refactor branch (split-pr-21-1782579575-refactor): files classified as cleanup / mechanical work:
    • utilities/unittests/test_console.py
  • Main branch (split-pr-21-1782579575-main): files classified as feature / behavior work:
    • utilities/console.py

Merge order

Merge the refactor PR first if it touches shared files or would conflict with the main PR; then merge the main PR. Resolve conflicts in the usual way if both branches touch the same lines.

Refactor PR: #31

To close this PR and delete its branch, comment @pull-apart /close.

@pull-apart pull-apart Bot mentioned this pull request Jun 27, 2026
@RoniKishner RoniKishner deleted the split-pr-21-1782579575-main branch June 27, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant