Skip to content

[split] Main changes — from #21#29

Closed
pull-apart[bot] wants to merge 1 commit into
mainfrom
split-pr-21-1782310171-main
Closed

[split] Main changes — from #21#29
pull-apart[bot] wants to merge 1 commit into
mainfrom
split-pr-21-1782310171-main

Conversation

@pull-apart

@pull-apart pull-apart Bot commented Jun 24, 2026

Copy link
Copy Markdown

Automated split from #21.

Context

This is the main / behavior half of an automated split from #21.

Changes in this PR:

  • utilities/console.py: Added imports for pty, shlex, subprocess, and pexpect.fdpexpect
  • Added _proc attribute to manage subprocess.Popen instance
  • Modified connect() to call _terminate_proc() on error path and updated console_eof_sampler() call
  • Modified disconnect() to check _proc.poll() status before re-spawning console and added _terminate_proc() call
  • Added _spawn_console() function to create a pty pair and wrap subprocess in pexpect.fdpexpect.fdspawn
  • Added _terminate_proc() function for graceful and forceful subprocess shutdown
  • Simplified console_eof_sampler() by removing parameters and using _spawn_console() internally
How this split maps your changes
  • Refactor branch (split-pr-21-1782310171-refactor): files classified as cleanup / mechanical work:
    • utilities/unittests/test_console.py
  • Main branch (split-pr-21-1782310171-main): files classified as feature / behavior work:
    • utilities/console.py

Merge order

Merge the refactor PR first if it touches shared files or would conflict with the main PR; then merge the main PR. Resolve conflicts in the usual way if both branches touch the same lines.

Refactor PR: #28

To close this PR and delete its branch, comment @pull-apart /close.

@RoniKishner

Copy link
Copy Markdown
Owner

@pull-apart /close

@pull-apart pull-apart Bot closed this Jun 24, 2026
@pull-apart pull-apart Bot deleted the split-pr-21-1782310171-main branch June 24, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant