[split] Main changes — from #21#27
Closed
pull-apart[bot] wants to merge 1 commit into
Closed
Conversation
Owner
|
@pull-apart /close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated split from #21.
Context
This is the main / behavior half of an automated split from #21. Branch
split-pr-21-1782307326-main.This PR contains only the main-assigned paths from that split (features, bug fixes, behavior changes). The refactor PR holds the sibling files.
Changes in this PR:
utilities/console.py: Adds_spawn_console()and_terminate_proc()to replacepexpect.spawnwithpty.openpty()andsubprocess.Popen, addressing aforkptydeprecation. Modifiesconnect(),disconnect(), andconsole_eof_sampler()to use the new process management.How this split maps your changes
split-pr-21-1782307326-refactor): files classified as cleanup / mechanical work:utilities/unittests/test_console.pysplit-pr-21-1782307326-main): files classified as feature / behavior work:utilities/console.pyMerge order
Merge the refactor PR first if it touches shared files or would conflict with the main PR; then merge the main PR. Resolve conflicts in the usual way if both branches touch the same lines.
Refactor PR: #26
To close this PR and delete its branch, comment
@pull-apart /close.