[split] Refactor / cleanup — from #21

[RoniKishner]

Automated split from #21.

Context

This is the refactor / cleanup half of an automated split from #21.

Changes in this PR:

• utilities/unittests/test_console.py: Added subprocess and pytest imports for expanded testing capabilities
• Introduced SingleAttemptTimeoutSampler helper class for mocking TimeoutSampler behavior in tests
• Updated test_console_disconnect_terminated_child to use new _proc.poll() check and simplified console_eof_sampler() call
• Updated test_console_eof_sampler_success and test_console_eof_sampler_no_sample to reflect changes in console_eof_sampler() signature and internal logic
• Added new test cases to cover _spawn_console() success and failure paths
• Added new test cases to verify _terminate_proc() functionality under various scenarios
• Added new test cases to ensure proper cleanup within connect() error paths and disconnect()

How this split maps your changes

• Refactor branch (split-pr-21-1782579575-refactor): files classified as cleanup / mechanical work:
  • utilities/unittests/test_console.py
• Main branch (split-pr-21-1782579575-main): files classified as feature / behavior work:
  • utilities/console.py

Merge order

Merge the refactor PR first if it touches shared files or would conflict with the main PR; then merge the main PR. Resolve conflicts in the usual way if both branches touch the same lines.

Main PR: #32

To close this PR and delete its branch, comment @pull-apart /close.