Remove redundant grid calculations in module_zone and fix clean-all in Makefile#8
Merged
Remove redundant grid calculations in module_zone and fix clean-all in Makefile#8
Conversation
… in Makefile Co-authored-by: peterus <1764325+peterus@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add OpenSCAD transmitter enclosure with Makefile build system
Remove redundant grid calculations in module_zone and fix clean-all in Makefile
Mar 14, 2026
There was a problem hiding this comment.
Pull request overview
Diese PR räumt redundante Berechnungen in den OpenSCAD-Enclosure-Dateien auf und verbessert das Build-/Cleanup-Verhalten im Enclosure-Makefile, damit generierte Render-Artefakte zuverlässiger entfernt werden können.
Changes:
module_zone.scad: Nutzung der inparameters.scadzentral definierten Grid-Abmessungen statt lokaler Neuberechnung.Makefile:clean-allentfernt nun den kompletten$(RENDER_DIR)-Baum (inkl.assembly/), undhelpunterscheidet klar zwischencleanundclean-all.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| hardware/transmitter/enclosure/modules/module_zone.scad | Ersetzt lokale Grid-Dimension-Berechnungen durch Referenzen auf zentrale Parameter. |
| hardware/transmitter/enclosure/Makefile | Macht clean-all tatsächlich „full clean“ und aktualisiert die Hilfeausgabe entsprechend. |
Comment on lines
+187
to
+188
| clean-all: | ||
| rm -rf $(RENDER_DIR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues flagged in code review:
module_zone.scadwas recomputing grid dimensions already defined inparameters.scad, andclean-allwas a no-op alias forclean.Changes
module_zone.scad: Replace localgrid_w/grid_drecomputations with direct references tobay_grid_width/bay_grid_heightfromparameters.scadMakefile:clean-allwas identical toclean(just delegated to it). Now removes the entire$(RENDER_DIR)/tree — includingassembly/exploded-view outputs not covered byclean. Updatedhelpoutput to reflect the distinction.clean-all: rm -rf $(RENDER_DIR)📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.