Skip to content

Remove redundant grid calculations in module_zone and fix clean-all in Makefile#8

Merged
peterus merged 2 commits intohw_framefrom
copilot/sub-pr-7
Mar 15, 2026
Merged

Remove redundant grid calculations in module_zone and fix clean-all in Makefile#8
peterus merged 2 commits intohw_framefrom
copilot/sub-pr-7

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 14, 2026

Two issues flagged in code review: module_zone.scad was recomputing grid dimensions already defined in parameters.scad, and clean-all was a no-op alias for clean.

Changes

  • module_zone.scad: Replace local grid_w/grid_d recomputations with direct references to bay_grid_width/bay_grid_height from parameters.scad

    // Before
    grid_w = bay_grid_cols * (bay_unit_size + bay_wall) + bay_wall;
    grid_d = bay_grid_rows * (bay_unit_size + bay_wall) + bay_wall;
    
    // After
    grid_w = bay_grid_width;
    grid_d = bay_grid_height;
  • Makefile: clean-all was identical to clean (just delegated to it). Now removes the entire $(RENDER_DIR)/ tree — including assembly/ exploded-view outputs not covered by clean. Updated help output to reflect the distinction.

    clean-all:
        rm -rf $(RENDER_DIR)

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

… in Makefile

Co-authored-by: peterus <1764325+peterus@users.noreply.github.com>
Copilot AI changed the title [WIP] Add OpenSCAD transmitter enclosure with Makefile build system Remove redundant grid calculations in module_zone and fix clean-all in Makefile Mar 14, 2026
Copilot AI requested a review from peterus March 14, 2026 09:52
@peterus peterus marked this pull request as ready for review March 15, 2026 09:44
Copilot AI review requested due to automatic review settings March 15, 2026 09:44
@peterus peterus merged commit a37ff25 into hw_frame Mar 15, 2026
@peterus peterus deleted the copilot/sub-pr-7 branch March 15, 2026 09:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Diese PR räumt redundante Berechnungen in den OpenSCAD-Enclosure-Dateien auf und verbessert das Build-/Cleanup-Verhalten im Enclosure-Makefile, damit generierte Render-Artefakte zuverlässiger entfernt werden können.

Changes:

  • module_zone.scad: Nutzung der in parameters.scad zentral definierten Grid-Abmessungen statt lokaler Neuberechnung.
  • Makefile: clean-all entfernt nun den kompletten $(RENDER_DIR)-Baum (inkl. assembly/), und help unterscheidet klar zwischen clean und clean-all.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
hardware/transmitter/enclosure/modules/module_zone.scad Ersetzt lokale Grid-Dimension-Berechnungen durch Referenzen auf zentrale Parameter.
hardware/transmitter/enclosure/Makefile Macht clean-all tatsächlich „full clean“ und aktualisiert die Hilfeausgabe entsprechend.

Comment on lines +187 to +188
clean-all:
rm -rf $(RENDER_DIR)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants