Conversation
Three-zone horizontal layout for the modular RC transmitter enclosure: Zones (front to back, each fits 200x200mm print bed): - Joystick Zone: 2x D400-R4 joysticks, ergonomic grips, battery cavity - Module Zone: 5x3 bay grid (30mm units), ESP32 + TCA9548A mux below - Display Zone: ILI9341 2.8" LCD in landscape, viewing window Design features: - Fully parametric (parameters.scad) - Tongue-and-groove inter-zone connections with M3 screws - Shared utility modules (rounded_cube, mounting_post, zone_shell, etc.) Build system (Makefile): - Auto-discovers .scad parts (no hardcoding needed) - PNG renders from 8 camera angles + exploded assembly view - STL export for 3D printing - Parallel build support (make -j) - Configurable resolution, colorscheme, views Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Dieser PR fügt ein vollständig parametrisches OpenSCAD-3D-Gehäusedesign für den OpenDriveHub-Transmitter hinzu, bestehend aus drei Zonen (Joystick, Modul, Display) mit Tongue-and-Groove-Verbindungen, sowie ein Makefile-Build-System für automatisierte PNG-Renders und STL-Exporte.
Changes:
- Neues parametrisches OpenSCAD-Gehäusedesign mit drei verbindbaren Zonen und gemeinsamen Utility-Modulen
- Makefile mit Auto-Discovery von
.scad-Dateien, 8 Kamerawinkel-Renders und STL-Export - Dokumentation (README) mit Druckrichtlinien, Stückliste und Montageanleitung
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
parameters.scad |
Zentrale Parameter für alle Dimensionen, Toleranzen und Visualisierung |
utils.scad |
Wiederverwendbare Module (rounded_cube, mounting_post, tongue/groove, zone_shell) |
joystick/joystick_zone.scad |
Vordere Zone mit 2 Joystick-Aufnahmen, Griffen und Batteriefach |
modules/module_zone.scad |
Mittlere Zone mit 5×3 Modul-Grid und ESP32/TCA9548A-Halterungen |
display/display_zone.scad |
Hintere Zone mit ILI9341-LCD-Aufnahme und Sichtfenster |
assembly.scad |
Gesamtmontageansicht mit Explosionsdarstellung und Dimensionsbericht |
Makefile |
Build-System mit Auto-Discovery, PNG-Rendering und STL-Export |
README.md |
Projektdokumentation mit Architektur, BOM und Druckhinweisen |
.gitignore |
Ignoriert generierte Render-Ausgaben |
Comment on lines
+41
to
+42
| grid_w = bay_grid_cols * (bay_unit_size + bay_wall) + bay_wall; | ||
| grid_d = bay_grid_rows * (bay_unit_size + bay_wall) + bay_wall; |
Comment on lines
+184
to
+188
| clean: | ||
| rm -rf $(foreach s,$(STEMS),$(RENDER_DIR)/$(s)) | ||
|
|
||
| clean-all: clean | ||
|
|
Owner
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Contributor
… in Makefile Co-authored-by: peterus <1764325+peterus@users.noreply.github.com>
Remove redundant grid calculations in module_zone and fix clean-all in Makefile
…ting posts and depth adjustments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three-zone horizontal layout for the modular RC transmitter enclosure:
Zones (front to back, each fits 200x200mm print bed):
Design features:
Build system (Makefile):