Skip to content

Remove redundant grid calculations in module_zone and fix clean-all in Makefile #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterus merged 2 commits into from
Mar 15, 2026
Merged

Remove redundant grid calculations in module_zone and fix clean-all in Makefile #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1348d50
Initial plan
Copilot Mar 14, 2026
5f8a725
Fix redundant grid_w/grid_d in module_zone.scad and improve clean-all…
Copilot Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions hardware/transmitter/enclosure/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@ $(RENDER_DIR)/assembly/exploded_%.png: assembly.scad $$(SCAD_DEPS)
clean:
rm -rf $(foreach s,$(STEMS),$(RENDER_DIR)/$(s))

clean-all: clean
clean-all:
rm -rf $(RENDER_DIR)
Comment on lines +187 to +188

# ─── Information ──────────────────────────────────────────────────────────────

Expand All @@ -204,7 +205,8 @@ help:
@echo " all / renders Render all parts in all views ($(words $(ALL_PNGS)) images)"
@echo " stl Export all parts as STL ($(words $(ALL_STLS)) files)"
@echo " assembly-exploded Exploded assembly renders"
@echo " clean Remove all generated files"
@echo " clean Remove per-part render directories"
@echo " clean-all Remove entire $(RENDER_DIR)/ directory"
@echo " list-parts Show auto-discovered parts"
@echo " help Show this help"
@echo ""
Expand Down
4 changes: 2 additions & 2 deletions hardware/transmitter/enclosure/modules/module_zone.scad
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ module module_zone() {
h = zone_height;

// Grid position (centered on X, centered on Y)
grid_w = bay_grid_cols * (bay_unit_size + bay_wall) + bay_wall;
grid_d = bay_grid_rows * (bay_unit_size + bay_wall) + bay_wall;
grid_w = bay_grid_width;
grid_d = bay_grid_height;
grid_x = (w - grid_w) / 2;
grid_y = (d - grid_d) / 2;

Expand Down
Loading