Skip to content

Update NodeJS to v24#94

Open
knopki wants to merge 1 commit intoilammy:masterfrom
knopki:bump-node-version-to-24
Open

Update NodeJS to v24#94
knopki wants to merge 1 commit intoilammy:masterfrom
knopki:bump-node-version-to-24

Conversation

@knopki
Copy link
Copy Markdown

@knopki knopki commented Nov 4, 2025

Gitub blog: Deprecation of Node 20 on GitHub Actions runners:

For Actions maintainers: Update your actions to run on Node24 instead of Node20

@pzhlkj6612
Copy link
Copy Markdown
Contributor

Fix #99

@sergio-nsk
Copy link
Copy Markdown

@ilammy Is the project alive?

@ManuLinares
Copy link
Copy Markdown

this repo is not maintaned, fork your own

@mk-pmb
Copy link
Copy Markdown

mk-pmb commented Mar 30, 2026

The PR makes commit fe7a075 part of this repo, so that we can temporarily use this syntax:

       - uses: ilammy/msvc-dev-cmd@fe7a075fb224e8557941ec7e7129d21e2c5d84e7

However, for me this fails with Error: Cannot find module '@actions/core' so there may be more to do than just the simple patch we're seeing so far.

@knopki
Copy link
Copy Markdown
Author

knopki commented Mar 30, 2026

@mk-pmb No, you need also #95 (or something that fixes dependencies).
I recommend forking the repository and using a fork. Alternatively, this action can be embedded in your repository - example.

richard-scott added a commit to richard-scott/msvc-dev-cmd that referenced this pull request Apr 26, 2026
GitHub Actions deprecated Node 20 actions in 2025-09 (changelog at
https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/);
default flips to Node 24 from 2026-06-02 and Node 20 is removed from
runners 2026-09-16. Triggers a deprecation annotation on every
matrix cell that uses this action under the current pin.

The action's only Node code is a thin shim around vcvarsall.bat —
no Node-version-specific APIs in index.js or lib.js, no native
modules in the bundled node_modules tree (just @actions/core@1.10.x
which is widely Node 16/18/20/24-compatible). Bumping the runtime
declaration is a one-line change with no anticipated behavioural
impact.

Fork rationale: upstream ilammy/msvc-dev-cmd v1.13.0 (2024-01-01) is
the latest release; default-branch tip is from 2024-03-30. Issue
ilammy#100 ("Update to Node 24") closed without merge,
PRs ilammy#99/ilammy#94/ilammy#101 unmerged. Repo appears unmaintained, deprecation
deadline is non-negotiable, fork is the lowest-cost path to a
Node 24-compatible action for our CI matrix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants