Update Node.js version and enhance workflow configuration #101
Update Node.js version and enhance workflow configuration #101blytkerchan wants to merge 12 commits intoilammy:masterfrom
Conversation
blytkerchan
commented
Mar 16, 2026
blytkerchan
commented
- Update Node.js version to 24 in action.yml
- Add Visual Studio 2025 version mapping to VsYearVersion
- Add 'dev' and 'main' branches to push trigger in workflow
- Fix typos in action.yml and lib.js comments
- Add dependabot configuration for npm and GitHub Actions updates
- Update actions/checkout version to v6 in main workflow
- Update GitHub Actions workflow to support Visual Studio 2025 and 2026
- Add configurable support for ARM32 architecture (to disable it where not supported)
- Fix compilation commands for ARM architecture in main workflow (don't always expect exe)
- Remove Windows 2019 runner from workflow matrix -- no longer supported
* Update Node.js version to 24 in action.yml * Add Visual Studio 2025 version mapping to VsYearVersion * Add 'dev' and 'main' branches to push trigger in workflow * Fix typos in action.yml and lib.js comments * Add dependabot configuration for npm and GitHub Actions updates * Update actions/checkout version to v6 in main workflow * Update GitHub Actions workflow to support Visual Studio 2025 and 2026 * Add configurable support for ARM32 architecture (to disable it where not supported) * Fix compilation commands for ARM architecture in main workflow (don't always expect exe) * Remove Windows 2019 runner from workflow matrix -- no longer supported
- Added @vercel/ncc as a devDependency in package.json - Updated the build script in package.json to use ncc for building the project - Updated package-lock.json to reflect the addition of @vercel/ncc
This is done here #94 |
|
Thank you for this PR, which made this fix very easy: steps:
- name: 'Install Visual Studio Build Tools'
- uses: ilammy/msvc-dev-cmd@v1
+ uses: ilammy/msvc-dev-cmd@138b1c783b65ec697d8342918306b7b2db4e88f1 |
|
Many projects use your GitHub action. If you no longer have the time or interest to maintain this project (which is perfectly fine), you could make another developer a collaborator who could continue the maintenance or help out for a certain period. The project would continue, and several people wouldn't have to create a fork. Imho that would be better for everyone (including you) than letting the project die. What do you think? I regularly contribute code to https://github.com/krakjoe/apcu, and this action is used there. Therefore, I would be happy if this project continues to work and I didn't have to worry about finding another solution... |
|
FWIW, I just found that someone has made their own forked MSVC action for some years and they are keeping maintaining it: https://github.com/TheMrMilchmann/setup-msvc-dev. I feel a little bit unhappy when I read the git-blame of that interesting "cls" hack: TheMrMilchmann/setup-msvc-dev::src/setup-msvc-dev.ts#L63-L64, which could be from ilammy/msvc-dev-cmd::index.js#L119. IIRC, MIT doesn't force anything about Git history, so I should calm down. However, we know that something is better than nothing. That's it. |
This comment was marked as outdated.
This comment was marked as outdated.
Someday you may want or need to build something with specific components, for example, an older Windows SDK. You need to call "vcvarsall.bat" and try to figure out how to persist those environment variables, then you see the core of this project.
. |
| @@ -12,6 +12,7 @@ const EDITIONS = ['Enterprise', 'Professional', 'Community', 'BuildTools'] | |||
| const YEARS = ['2022', '2019', '2017'] | |||
There was a problem hiding this comment.
| const YEARS = ['2022', '2019', '2017'] | |
| const YEARS = ['2026', '2022', '2019', '2017'] |
There was a problem hiding this comment.
There was a problem hiding this comment.
TBH, to me it looks like this change probably isn't necessary at the moment, because the year seems not to be part of the path in this VS version. But if this changes someday, it could be useful and it shouldn't harm.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
GitHub Actions deprecated Node 20 actions in 2025-09 (changelog at https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/); default flips to Node 24 from 2026-06-02 and Node 20 is removed from runners 2026-09-16. Triggers a deprecation annotation on every matrix cell that uses this action under the current pin. The action's only Node code is a thin shim around vcvarsall.bat — no Node-version-specific APIs in index.js or lib.js, no native modules in the bundled node_modules tree (just @actions/core@1.10.x which is widely Node 16/18/20/24-compatible). Bumping the runtime declaration is a one-line change with no anticipated behavioural impact. Fork rationale: upstream ilammy/msvc-dev-cmd v1.13.0 (2024-01-01) is the latest release; default-branch tip is from 2024-03-30. Issue ilammy#100 ("Update to Node 24") closed without merge, PRs ilammy#99/ilammy#94/ilammy#101 unmerged. Repo appears unmaintained, deprecation deadline is non-negotiable, fork is the lowest-cost path to a Node 24-compatible action for our CI matrix.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
