Skip to content

Update to Node 24#100

Closed
the-phinet wants to merge 1 commit intoilammy:masterfrom
the-phinet:master
Closed

Update to Node 24#100
the-phinet wants to merge 1 commit intoilammy:masterfrom
the-phinet:master

Conversation

@the-phinet
Copy link
Copy Markdown

@the-phinet the-phinet commented Mar 13, 2026

Fixes #99

Even though this doesn't seem to break anything on my end, it probably needs more testing to see if there are any regressions introduced by doing this.

@pzhlkj6612
Copy link
Copy Markdown
Contributor

duplicate of #94

@the-phinet
Copy link
Copy Markdown
Author

duplicate of #94

Crap, how did I not see that. Thanks!

@the-phinet the-phinet closed this Mar 14, 2026
richard-scott added a commit to richard-scott/msvc-dev-cmd that referenced this pull request Apr 26, 2026
GitHub Actions deprecated Node 20 actions in 2025-09 (changelog at
https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/);
default flips to Node 24 from 2026-06-02 and Node 20 is removed from
runners 2026-09-16. Triggers a deprecation annotation on every
matrix cell that uses this action under the current pin.

The action's only Node code is a thin shim around vcvarsall.bat —
no Node-version-specific APIs in index.js or lib.js, no native
modules in the bundled node_modules tree (just @actions/core@1.10.x
which is widely Node 16/18/20/24-compatible). Bumping the runtime
declaration is a one-line change with no anticipated behavioural
impact.

Fork rationale: upstream ilammy/msvc-dev-cmd v1.13.0 (2024-01-01) is
the latest release; default-branch tip is from 2024-03-30. Issue
ilammy#100 ("Update to Node 24") closed without merge,
PRs ilammy#99/ilammy#94/ilammy#101 unmerged. Repo appears unmaintained, deprecation
deadline is non-negotiable, fork is the lowest-cost path to a
Node 24-compatible action for our CI matrix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to Node 24

2 participants