Add editorial_pkg product type to thumbnail extractor#1860
Open
jakubjezek001 wants to merge 2 commits into
Open
Add editorial_pkg product type to thumbnail extractor#1860jakubjezek001 wants to merge 2 commits into
editorial_pkg product type to thumbnail extractor#1860jakubjezek001 wants to merge 2 commits into
Conversation
ynbot
added
size/XS
type: enhancement
jakubjezek001
changed the title
editorial_pkg product type to thumbnail extractor
BigRoy
reviewed
May 26, 2026
Member
BigRoy
left a comment
BigRoy
left a comment
There was a problem hiding this comment.
Change seems fine to me, but I'd rather look at whether we can just improve this logic so that it's the go-to way to make thumbnails everywhere?
Comment on lines
96
to
113
| families = [ | ||
| "imagesequence", "render", "render2d", "prerender", | ||
| "source", "clip", "take", "online", "image" | ||
| "source", "clip", "take", "online", "image", "editorial_pkg" | ||
| ] | ||
| hosts = [ | ||
| "shell", | ||
| "fusion", | ||
| "resolve", | ||
| "traypublisher", | ||
| "substancepainter", | ||
| "substancedesigner", | ||
| "nuke", | ||
| "aftereffects", | ||
| "photoshop", | ||
| "unreal", | ||
| "houdini", | ||
| "batchdelivery", | ||
| ] |
Member
There was a problem hiding this comment.
Looking at this process method @jakubjezek001 @antirotor @iLLiCiTiT do we see any reason why this needs hosts + families filtering to begin with? Why couldn't this just be enabled for everything?
Member
Author
There was a problem hiding this comment.
very good question, I would love to know myself. Could there be any collision with ExtractThumbnailFromSource? @iLLiCiTiT
…kage-lacking-thumbnail-for-ftrack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
editorial_pkgwas missing from the supportedfamiliesin theExtractThumbnailplugin, causing editorial package products to never generate thumbnails.Additional info
Single-line change in
client/ayon_core/plugins/publish/extract_thumbnail.py—"editorial_pkg"appended to thefamilieslist of theExtractThumbnailpyblish plugin.Testing notes:
editorial_pkginstances).Dependency
Close #1859
YN-0626