Skip to content

Farm: soft fail CollectRenderedFiles if env var not set#1854

Merged
antirotor merged 4 commits into
developfrom
bugfix/soft-fail-collect-rendered-files
May 25, 2026
Merged

Farm: soft fail CollectRenderedFiles if env var not set#1854
antirotor merged 4 commits into
developfrom
bugfix/soft-fail-collect-rendered-files

Conversation

@antirotor
Copy link
Copy Markdown
Member

@antirotor antirotor commented May 21, 2026

Changelog Description

soft-fail when AYON_PUBLISH_DATA is not set with farm target and shell host.

Additional info

Unsuccessful check for the AYON_PUBLISH_DATA var crash the whole publishing on target farm even if this plugin is not used at all. This plugin is used only for publishing with metadata.json. This allows publishing on Deadline Cloud.

Testing notes:

Nothing should really fail as AYON_PUBLISH_DATA is set when needed (and if it is not, it is probably bug of the publish job submitter).

Note

This is needed for testing ynput/ayon-deadline-cloud#19

unsuccessful check for the `AYON_PUBLISH_DATA` var crash the whole publishing on target `farm` even if this plugin is not used at all.
@antirotor antirotor requested review from BigRoy and iLLiCiTiT May 21, 2026 16:33
@antirotor antirotor self-assigned this May 21, 2026
@antirotor antirotor added the type: bug Something isn't working label May 21, 2026
@ynbot ynbot added the size/XS label May 21, 2026
Comment thread client/ayon_core/plugins/publish/collect_rendered_files.py Outdated
@ynbot ynbot moved this to Review In Progress in PR reviewing May 21, 2026
Copy link
Copy Markdown
Member

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@github-project-automation github-project-automation Bot moved this from Review In Progress to Merge Requested in PR reviewing May 21, 2026
@antirotor antirotor merged commit 69b8608 into develop May 25, 2026
2 checks passed
@antirotor antirotor deleted the bugfix/soft-fail-collect-rendered-files branch May 25, 2026 09:12
@github-project-automation github-project-automation Bot moved this from Merge Requested to Done in PR reviewing May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS type: bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants