Skip to content

Run plug-ins regardless of hosts: Collect Audio, Extract Review, Extract Burnin and Clean Up#1810

Open
BigRoy wants to merge 6 commits into
developfrom
enhancement/pyblish_reduce_hosts_requirements
Open

Run plug-ins regardless of hosts: Collect Audio, Extract Review, Extract Burnin and Clean Up#1810
BigRoy wants to merge 6 commits into
developfrom
enhancement/pyblish_reduce_hosts_requirements

Conversation

@BigRoy
Copy link
Copy Markdown
Member

@BigRoy BigRoy commented Apr 29, 2026

Changelog Description

Run plug-ins regardless of hosts: Collect Audio, Extract Review, Extract Burnin and Clean Up.

Additional info

This will most definitely have side-effects.

Particularly because suddenly these plug-ins will trigger on hosts that previously were not in these lists.
I'd especially investigate the more esoteric hosts - like webpublisher, batch publisher or certain ones like mocha.

Note that, except for Clean Up plug-in these changed plug-ins only target "review" family (and Extract Burnin also "burnin" family; although I know no case where we add burnin as family)

If we find one plug-in particularly dangerous to change, we can move it into a separate PR - e.g. the Clean Up one.

Testing notes:

  • Clean Up plug-in does not cause problems in:
    • batchdelivery host
    • traypublisher host
    • (3ds)max host
  • Collect Folder Audio plug-in ('review' family only) does not cause problems in:
    • workflow host for 'review' family
  • All these plug-ins do not cause problems in:
    • Mocha
    • 3dequalizer
    • ... and more hosts that were missing

@BigRoy BigRoy requested review from antirotor and iLLiCiTiT April 29, 2026 08:12
@BigRoy BigRoy self-assigned this Apr 29, 2026
@BigRoy BigRoy added the type: enhancement Improvement of existing functionality or minor addition label Apr 29, 2026
@ynbot ynbot added the size/XS label Apr 29, 2026
@iLLiCiTiT
Copy link
Copy Markdown
Member

I'd really love to approve it, but it has to be tested in hosts I even don't know how to use 😞 .

Will try traypublisher with the cleanup plugin, but I do believe that one will cause issues.

@iLLiCiTiT
Copy link
Copy Markdown
Member

iLLiCiTiT commented Apr 29, 2026

So, traypublisher and cleanup, for all cases instances have staging set to temp directory and that is marked for explicit cleanup, except for editorial publishing, that one needs retest.

EDITED:
Editorial is ok, because it is not in temp it is skipped.

@BigRoy BigRoy requested review from LiborBatek and moonyuet May 1, 2026 07:50
Copy link
Copy Markdown
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely has side-effect to 3dsmax host, of which I will make the PR for the change in regards of that.

@BigRoy
Copy link
Copy Markdown
Member Author

BigRoy commented May 26, 2026

I'd say, let's merge @iLLiCiTiT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants