Run plug-ins regardless of hosts: Collect Audio, Extract Review, Extract Burnin and Clean Up#1810
Open
BigRoy wants to merge 6 commits into
Open
Run plug-ins regardless of hosts: Collect Audio, Extract Review, Extract Burnin and Clean Up#1810BigRoy wants to merge 6 commits into
BigRoy wants to merge 6 commits into
Conversation
Member
|
I'd really love to approve it, but it has to be tested in hosts I even don't know how to use 😞 . Will try traypublisher with the cleanup plugin, but I do believe that one will cause issues. |
Member
|
So, traypublisher and cleanup, for all cases instances have staging set to temp directory and that is marked for explicit cleanup, except for editorial publishing, that one needs retest. EDITED: |
moonyuet
approved these changes
May 1, 2026
Member
moonyuet
left a comment
There was a problem hiding this comment.
It definitely has side-effect to 3dsmax host, of which I will make the PR for the change in regards of that.
jakubjezek001
approved these changes
May 26, 2026
Member
Author
|
I'd say, let's merge @iLLiCiTiT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Run plug-ins regardless of hosts: Collect Audio, Extract Review, Extract Burnin and Clean Up.
Additional info
This will most definitely have side-effects.
Particularly because suddenly these plug-ins will trigger on hosts that previously were not in these lists.
I'd especially investigate the more esoteric hosts - like webpublisher, batch publisher or certain ones like mocha.
Note that, except for Clean Up plug-in these changed plug-ins only target "review" family (and Extract Burnin also "burnin" family; although I know no case where we add burnin as family)
If we find one plug-in particularly dangerous to change, we can move it into a separate PR - e.g. the Clean Up one.
Testing notes: