Publish as AYON reviewable#18
Merged
Merged
Conversation
tweak-wtf
changed the title
BigRoy
reviewed
May 13, 2026
Member
BigRoy
left a comment
BigRoy
left a comment
There was a problem hiding this comment.
Usually instead of directly passing on to webreview it goes through Extract Review (and perhaps Extract Burnin). For that it should:
- Have 'review' family applied to the instance
- Must have set
instance.data["review"] = True - Must have
"review" in representation["tags"]for the representation ininstance.data["representations"](sowebreview->review) - There is the caveat that currently Extract Review is ALSO hosts filtered 🤦♂️ but that's being addressed here: ynput/ayon-core#1810
I think if we make it go through 'review' steps it behaves more like other DCC integrations, and also has a higher chance the web review upload is of an optimized web playing format for the web reviews.
@iLLiCiTiT or would you approach otherwise?
Member
|
It should go through Extract Review because the conversion for AYON server is more and more mandatory. |
…ass Extract Review
…ass Extract Review (update families)
…ass Extract Review
Collaborator
|
Thanks for clarifying @BigRoy @iLLiCiTiT, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
webreviewtag to image/review products in order to automatically upload them to AYON as a reviewable representation.Since this addon exclusively supports AYON web-reviewable media (png, mp4, webm) i think it's safe to always add the tag.