Skip to content

add roleSlug for createOrgMembership and fix updateOrgMemberhship #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jameslcarpino merged 2 commits into from
May 9, 2025
+12 −7
Merged

add roleSlug for createOrgMembership and fix updateOrgMemberhship #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f49a49
add roleSlug param for createOrgMembership and fix updateOrgMemberhsi…
jameslcarpino May 6, 2025
cf780b4
remove runtime type check and print statements
jameslcarpino May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions lib/UserManagement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,18 +218,20 @@ public function deleteUser($userId)
*
* @param string $userId User ID
* @param string $organizationId Organization ID
* @param string|null $roleSlug Role Slug
*
* @throws Exception\WorkOSException
*
* @return Resource\OrganizationMembership
*/
public function createOrganizationMembership($userId, $organizationId)
public function createOrganizationMembership($userId, $organizationId, $roleSlug = null)
{
$path = "user_management/organization_memberships";

$params = [
"organization_id" => $organizationId,
"user_id" => $userId
"user_id" => $userId,
"role_slug" => $roleSlug
];

$response = Client::request(
Expand Down Expand Up @@ -295,18 +297,18 @@ public function deleteOrganizationMembership($organizationMembershipId)
* Update a User organization membership.
*
* @param string $organizationMembershipId Organization Membership ID
* @param string $role_slug The unique role identifier.
* @param string|null $role_slug The unique role identifier.
*
* @throws Exception\WorkOSException
*
* @return Resource\OrganizationMembership
*/
public function updateOrganizationMembership($organizationMembershipId, $role_slug)
public function updateOrganizationMembership($organizationMembershipId, $roleSlug = null)
{
$path = "user_management/organization_memberships/{$organizationMembershipId}";

$params = [
"role_slug" => $role_slug
"role_slug" => $roleSlug
];

$response = Client::request(
Expand Down
7 changes: 5 additions & 2 deletions tests/WorkOS/UserManagementTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,13 +837,15 @@ public function testCreateOrganizationMembership()
{
$userId = "user_01H7X1M4TZJN5N4HG4XXMA1234";
$orgId = "org_01EHQMYV6MBK39QC5PZXHY59C3";
$roleSlug = "admin";
$path = "user_management/organization_memberships";

$result = $this->organizationMembershipResponseFixture();

$params = [
"organization_id" => $orgId,
"user_id" => $userId
"user_id" => $userId,
"role_slug" => $roleSlug
];

$this->mockRequest(
Expand All @@ -857,7 +859,8 @@ public function testCreateOrganizationMembership()

$organizationMembership = $this->organizationMembershipFixture();

$response = $this->userManagement->createOrganizationMembership($userId, $orgId);
$response = $this->userManagement->createOrganizationMembership($userId, $orgId, $roleSlug);

$this->assertSame($organizationMembership, $response->toArray());
}

Expand Down