add roleSlug for createOrgMembership and fix updateOrgMemberhship#278
Merged
Conversation
…p to allow for optional value for roleSlug
mattgd
reviewed
May 6, 2025
mattgd
left a comment
mattgd
left a comment
Contributor
There was a problem hiding this comment.
One minor comment but looks good otherwise.
Comment on lines
+863
to
+864
| echo "Response from Create Org:"; | ||
| print_r($response); |
Contributor
There was a problem hiding this comment.
Looks like this was just for debugging and probably meant to be removed.
gcarvelli
reviewed
May 6, 2025
| ); | ||
| if (!is_null($roleSlug) && !is_string($roleSlug)) { | ||
| throw new \InvalidArgumentException("roleSlug must be a string or null"); | ||
| } |
Contributor
There was a problem hiding this comment.
We don't generally do runtime type checks for parameters like this. The typehint phpdoc comment should be enough.
gcarvelli
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds roleSlug param on createOrgMembership. Allows for updateOrgMembership to not require roleSlug.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.