revert(core): unmerge i18n stack base#1707
Merged
Merged
Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c451ef3. Configure here.
Contributor
📦 Bundle Size Report🎨 @videojs/html
Presets (7)
Media (10)
Players (5)
Skins (30)
UI Components (38)
Sizes are marginal over the root entry point. ⚛️ @videojs/react
Presets (7)
Media (9)
Skins (27)
UI Components (32)
Sizes are marginal over the root entry point. 🧩 @videojs/core
Entries (14)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils
Entries (10)
📦 @videojs/spf — no changesEntries (4)
ℹ️ How to interpretAll sizes are standalone totals (minified + brotli).
Run |
mihar-22
approved these changes
Jun 18, 2026
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the accidental squash merges of #1589 and #1590 so the i18n stack can be reviewed and merged in order again.
Changes
Testing
Note
High Risk
Large removal of a public
@videojs/core/i18nAPI and all shipped locale packs; any code or docs still expecting the merged stack will break until the stacked PRs land again.Overview
Rolls back the squashed i18n foundation and locale-pack work so the stack can land again in sequence.
@videojs/core/i18nis removed end-to-end: registry, translator, browser translation,loadLocale, codegen (generate-i18n-locales), 50+ locale files, tests, andpackage.jsonexports /sideEffectsfor i18n.pnpm check:workspaceno longer validates locale consistency.UI cores go back to hardcoded English control labels (e.g.
'Enable captions','Start casting') instead of opaque i18n keys andresolveOptionalControlLabel. Related core exports (error-dialog i18n, input-feedback labels, resolve-control helpers) are dropped with that layer.internal/design/i18n.mdis marked draft again and rewritten toward a smaller key set and simpler provider story (distinct from the reverted implementation).Note: The diff may be incomplete relative to the PR title (e.g. html/react i18n packages)—anything still importing removed core i18n paths would need follow-up in the revert branch.
Reviewed by Cursor Bugbot for commit 371af75. Bugbot is set up for automated code reviews on this repo. Configure here.