Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Size Report🎨 @videojs/html
Presets (7)
Media (10)
Players (5)
Skins (30)
UI Components (38)
Sizes are marginal over the root entry point. ⚛️ @videojs/react
Presets (7)
Media (9)
Skins (27)
UI Components (32)
Sizes are marginal over the root entry point. 🧩 @videojs/core
Entries (69)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils
Entries (10)
📦 @videojs/spf — no changesEntries (4)
ℹ️ How to interpretJS sizes are initial static graph totals (minified + brotli). Lazy dynamic chunks are shown separately when present.
Run |
sampotts
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3d1a240. Configure here.
| "sideEffects": false, | ||
| "sideEffects": [ | ||
| "**/i18n/registry.js" | ||
| ], |
There was a problem hiding this comment.
sideEffects omits bundled i18n entry
Medium Severity
sideEffects only lists **/i18n/registry.js, but the published @videojs/core/i18n entry is a single i18n bundle that inlines registry.ts (including pre-registering en). Bundlers that honor sideEffects may tree-shake away registry initialization when consumers import named exports from @videojs/core/i18n, leaving translations without the English base layer.
Reviewed by Cursor Bugbot for commit 3d1a240. Configure here.
| if (!expectedPlatform.has(tag)) { | ||
| warnings.push(`Unexpected locale re-export packages/${pkg}/src/i18n/locales/${file}`); | ||
| } | ||
| } |
There was a problem hiding this comment.
Workspace check crashes missing locale dirs
Low Severity
Check 7 calls readdirSync on packages/html/src/i18n/locales and packages/react/src/i18n/locales without verifying those directories exist. If locale stubs were not generated yet, pnpm check:workspace throws instead of reporting a clear warning like the per-file existsSync checks above.
Reviewed by Cursor Bugbot for commit 3d1a240. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1589
Refs #1590
Summary
Restores the combined i18n foundation and locale-pack work from the two accidentally merged PRs after #1707 reverted them out of main.
feat/i18nwill be the feature branch the other stacked PRs merge into and this PR will be used to merge the whole feature intomain:main← #1708
feat/i18n← #1591
feat/i18n-html← #1595
feat/i18n-react← #1593
feat/i18n-sandbox← #1600
docs/i18nNote
Medium Risk
Large, user-facing change to labels and accessibility across controls and many locales; risk is mitigated by tests, codegen checks, and restoring previously reviewed design, but regressions in string keys or locale loading would affect all skins.
Overview
Restores the Video.js 10 i18n stack that was reverted from main: a new
@videojs/core/i18nentry with a global registry, typedcreateTranslator,loadLocalelazy imports, 50+ shipped locale packs (v8 parity), and optional Chrome Translator API fallback (getBrowserTranslations/shouldAttemptBrowserTranslation).Codegen & CI:
generate-i18n-locales.tsruns on@videojs/coreprebuild, regeneratinglocales/all.ts,load-locale.ts, and html/react locale re-export stubs;check-workspacegains an i18n locales consistency check.package.jsonadds./i18nand./i18n/locales/*exports and marks the registry as a side effect.Player copy: English defaults live in
locales/en.tswith an expanded key set (live/cast, sliders, indicators, error dialog,timeRemainingPhrase, etc.). UI cores (e.g. captions/cast and others in the diff) now expose opaque label keys viaresolveOptionalControlLabelinstead of hardcoded English; related tests andinternal/design/i18n.mdare updated to implemented status and document provider merge order, tooltips, andloadLocale.Reviewed by Cursor Bugbot for commit 3d1a240. Bugbot is set up for automated code reviews on this repo. Configure here.