HSETEX - Always issue keyspace notifications after validation by ranshid · Pull Request #3001 · valkey-io/valkey

ranshid · 2026-01-03T13:53:12Z

In the original implementation of Hash Field Expiration (#2089), the HSETEX command was implemented to report keyspace notifications only for performed changes. This is mostly aligned with other Hash commands (for example, HDEL will also not report hdel event for items which does not exist)
The HSETEX case is somewhat different and is more like the HSET case. During HSETEX, after the command validations pass, items are ALWAYS "added" to the object, even though they might not actually be added.
This case is the same for when the hash object is empty or when all the provided fields do not exist in the object (as reported here)

This PR changes the way HSETEX will report keyspace notifications so that:

hset notification will ALWAYS be reported if all command validations pass.
hexpire will be reported in case the command include an expiration time (even past time)
hxpired will be reported in case the provided expiration time is in the past (or 0)
hdel will be reported in case the hash exists (or created as part of the command) and following the command execution it was left empty.
we will always return '1' as a return value of tHSETEX command which passed all validations. Before that we returned 1 only if we applied the change cross ALL the input fields, so in case some of them did not exist and a past time was set we would return 0.

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

ranshid · 2026-01-03T13:54:03Z

currently making this a draft for when #2998 is merged

codecov · 2026-01-03T14:12:34Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.90%. Comparing base (928e912) to head (29091af).
⚠️ Report is 10 commits behind head on unstable.

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #3001      +/-   ##
============================================
- Coverage     74.93%   74.90%   -0.03%     
============================================
  Files           129      129              
  Lines         71145    71201      +56     
============================================
+ Hits          53310    53335      +25     
- Misses        17835    17866      +31

Files with missing lines	Coverage Δ
src/t_hash.c	`95.46% <100.00%> (+0.08%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ort-keyspace-events Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

madolson · 2026-01-05T05:09:26Z

So, I guess we either:

Think this is a breaking change, and do it in 10.0
We think this is a bugfix, and we backport it.

Do we have a preference between those two?

ranshid · 2026-01-05T11:18:01Z

So, I guess we either:

Think this is a breaking change, and do it in 10.0

We think this is a bugfix, and we backport it.

Do we have a preference between those two?

TBH I am not sure how much this new feature adoption is big so I would love to make it ASAP.
Regarding the "bugfix" route - I guess this is fine by me and will save more confusion than a future "behavioural change"

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

…ort-keyspace-events

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

…ort-keyspace-events

…3120) The test is currently flakey, because until we merge: #3001 when the expiration time provided is in the past, and the field does not exist the HSETX will just silently ignore it, without incrementing the statistics. I prefer to focus on writing a dedicated test for: #3001 and deflake this test now. Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

…alkey-io#3120) The test is currently flakey, because until we merge: valkey-io#3001 when the expiration time provided is in the past, and the field does not exist the HSETX will just silently ignore it, without incrementing the statistics. I prefer to focus on writing a dedicated test for: valkey-io#3001 and deflake this test now. Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

madolson

I think this is right, and is worth backporting and calling out as a bug fix.

…3120) The test is currently flakey, because until we merge: #3001 when the expiration time provided is in the past, and the field does not exist the HSETX will just silently ignore it, without incrementing the statistics. I prefer to focus on writing a dedicated test for: #3001 and deflake this test now. Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

Co-authored-by: Jacob Murphy <jkmurphy@google.com> Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

…-io#3001) In the original implementation of Hash Field Expiration (valkey-io#2089), the HSETEX command was implemented to report keyspace notifications only for performed changes. This is mostly aligned with other Hash commands (for example, HDEL will also not report `hdel` event for items which does not exist) The HSETEX case is somewhat different and is more like the `HSET` case. During HSETEX, after the command validations pass, items are ALWAYS "added" to the object, even though they might not actually be added. This case is the same for when the hash object is empty or when all the provided fields do not exist in the object (as reported [here](valkey-io#2998)) This PR changes the way `HSETEX` will report keyspace notifications so that: 1. `hset` notification will ALWAYS be reported if all command validations pass. 2. `hexpire` will be reported in case the command include an expiration time (even past time) 3. `hxpired` will be reported in case the provided expiration time is in the past (or 0) 4. `hdel` will be reported in case the hash exists (or created as part of the command) and following the command execution it was left empty. 5. we will always return '1' as a return value of tHSETEX command which passed all validations. Before that we returned 1 only if we applied the change cross ALL the input fields, so in case some of them did not exist and a past time was set we would return 0. --------- Signed-off-by: Ran Shidlansik <ranshid@amazon.com> Co-authored-by: Jacob Murphy <jkmurphy@google.com>

In the original implementation of Hash Field Expiration (#2089), the HSETEX command was implemented to report keyspace notifications only for performed changes. This is mostly aligned with other Hash commands (for example, HDEL will also not report `hdel` event for items which does not exist) The HSETEX case is somewhat different and is more like the `HSET` case. During HSETEX, after the command validations pass, items are ALWAYS "added" to the object, even though they might not actually be added. This case is the same for when the hash object is empty or when all the provided fields do not exist in the object (as reported [here](#2998)) This PR changes the way `HSETEX` will report keyspace notifications so that: 1. `hset` notification will ALWAYS be reported if all command validations pass. 2. `hexpire` will be reported in case the command include an expiration time (even past time) 3. `hxpired` will be reported in case the provided expiration time is in the past (or 0) 4. `hdel` will be reported in case the hash exists (or created as part of the command) and following the command execution it was left empty. 5. we will always return '1' as a return value of tHSETEX command which passed all validations. Before that we returned 1 only if we applied the change cross ALL the input fields, so in case some of them did not exist and a past time was set we would return 0. --------- Signed-off-by: Ran Shidlansik <ranshid@amazon.com> Co-authored-by: Jacob Murphy <jkmurphy@google.com> Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

…alkey-io#3120) The test is currently flakey, because until we merge: valkey-io#3001 when the expiration time provided is in the past, and the field does not exist the HSETX will just silently ignore it, without incrementing the statistics. I prefer to focus on writing a dedicated test for: valkey-io#3001 and deflake this test now. Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

…-io#3001) In the original implementation of Hash Field Expiration (valkey-io#2089), the HSETEX command was implemented to report keyspace notifications only for performed changes. This is mostly aligned with other Hash commands (for example, HDEL will also not report `hdel` event for items which does not exist) The HSETEX case is somewhat different and is more like the `HSET` case. During HSETEX, after the command validations pass, items are ALWAYS "added" to the object, even though they might not actually be added. This case is the same for when the hash object is empty or when all the provided fields do not exist in the object (as reported [here](valkey-io#2998)) This PR changes the way `HSETEX` will report keyspace notifications so that: 1. `hset` notification will ALWAYS be reported if all command validations pass. 2. `hexpire` will be reported in case the command include an expiration time (even past time) 3. `hxpired` will be reported in case the provided expiration time is in the past (or 0) 4. `hdel` will be reported in case the hash exists (or created as part of the command) and following the command execution it was left empty. 5. we will always return '1' as a return value of tHSETEX command which passed all validations. Before that we returned 1 only if we applied the change cross ALL the input fields, so in case some of them did not exist and a past time was set we would return 0. --------- Signed-off-by: Ran Shidlansik <ranshid@amazon.com> Co-authored-by: Jacob Murphy <jkmurphy@google.com>

…alkey-io#3120) The test is currently flakey, because until we merge: valkey-io#3001 when the expiration time provided is in the past, and the field does not exist the HSETX will just silently ignore it, without incrementing the statistics. I prefer to focus on writing a dedicated test for: valkey-io#3001 and deflake this test now. Signed-off-by: Ran Shidlansik <ranshid@amazon.com> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>

…-io#3001) In the original implementation of Hash Field Expiration (valkey-io#2089), the HSETEX command was implemented to report keyspace notifications only for performed changes. This is mostly aligned with other Hash commands (for example, HDEL will also not report `hdel` event for items which does not exist) The HSETEX case is somewhat different and is more like the `HSET` case. During HSETEX, after the command validations pass, items are ALWAYS "added" to the object, even though they might not actually be added. This case is the same for when the hash object is empty or when all the provided fields do not exist in the object (as reported [here](valkey-io#2998)) This PR changes the way `HSETEX` will report keyspace notifications so that: 1. `hset` notification will ALWAYS be reported if all command validations pass. 2. `hexpire` will be reported in case the command include an expiration time (even past time) 3. `hxpired` will be reported in case the provided expiration time is in the past (or 0) 4. `hdel` will be reported in case the hash exists (or created as part of the command) and following the command execution it was left empty. 5. we will always return '1' as a return value of tHSETEX command which passed all validations. Before that we returned 1 only if we applied the change cross ALL the input fields, so in case some of them did not exist and a past time was set we would return 0. --------- Signed-off-by: Ran Shidlansik <ranshid@amazon.com> Co-authored-by: Jacob Murphy <jkmurphy@google.com> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker.io/valkey/valkey](https://github.com/valkey-io/valkey) | image | patch | `9.0.1` → `9.0.4` | --- ### Release Notes <details> <summary>valkey-io/valkey (docker.io/valkey/valkey)</summary> ### [`v9.0.4`](https://github.com/valkey-io/valkey/releases/tag/9.0.4) [Compare Source](valkey-io/valkey@9.0.3...9.0.4) Upgrade urgency SECURITY: This release includes security fixes we recommend you apply as soon as possible. ##### Security fixes - (CVE-2026-23479) Use-After-Free in unblock client flow - (CVE-2026-25243) Invalid Memory Access in RESTORE command - (CVE-2026-23631) Use-after-free when full sync occurs during a yielding Lua/function execution ### [`v9.0.3`](https://github.com/valkey-io/valkey/releases/tag/9.0.3) [Compare Source](valkey-io/valkey@9.0.2...9.0.3) ##### Valkey 9.0.3 Upgrade urgency SECURITY: This release includes security fixes we recommend you apply as soon as possible. ##### Security fixes - (CVE-2025-67733) RESP Protocol Injection via Lua error\_reply - (CVE-2026-21863) Remote DoS with malformed Valkey Cluster bus message - (CVE-2026-27623) Reset request type after handling empty requests ##### Bug fixes - Avoids crash during MODULE UNLOAD when ACL rules reference a module command and subcommand ([#3160](valkey-io/valkey#3160)) - Fix server assert on ACL LOAD when current user loses permission to channels ([#3182](valkey-io/valkey#3182)) - Fix bug causing no response flush sometimes when IO threads are busy ([#3205](valkey-io/valkey#3205)) ### [`v9.0.2`](https://github.com/valkey-io/valkey/releases/tag/9.0.2) [Compare Source](valkey-io/valkey@9.0.1...9.0.2) Upgrade urgency HIGH: There are critical bugs that may affect a subset of users. #### Bug fixes - Avoid memory leak of new argv when HEXPIRE commands target only non-exiting fields ([#2973](valkey-io/valkey#2973)) - Fix HINCRBY and HINCRBYFLOAT to update volatile key tracking ([#2974](valkey-io/valkey#2974)) - Avoid empty hash object when HSETEX added no fields ([#2998](valkey-io/valkey#2998)) - Fix case-sensitive check for the FNX and FXX arguments in HSETEX ([#3000](valkey-io/valkey#3000)) - Prevent assertion in active expiration job after a hash with volatile fields is overwritten ([#3003](valkey-io/valkey#3003), [#3007](valkey-io/valkey#3007)) - Fix HRANDFIELD to return null response when no field could be found ([#3022](valkey-io/valkey#3022)) - Fix HEXPIRE to not delete items when validation rules fail and expiration is in the past ([#3023](valkey-io/valkey#3023), [#3048](valkey-io/valkey#3048)) - Fix how hash is handling overriding of expired fields overwrite ([#3060](valkey-io/valkey#3060)) - HSETEX - Always issue keyspace notifications after validation ([#3001](valkey-io/valkey#3001)) - Make zero a valid TTL for hash fields during import mode and data loading ([#3006](valkey-io/valkey#3006)) - Trigger prepareCommand on argc change in module command filters ([#2945](valkey-io/valkey#2945)) - Restrict TTL from being negative and avoid crash in import-mode ([#2944](valkey-io/valkey#2944)) - Fix chained replica crash when doing dual channel replication ([#2983](valkey-io/valkey#2983)) - Skip slot cache optimization for AOF client to prevent key duplication and data corruption ([#3004](valkey-io/valkey#3004)) - Fix used\_memory\_dataset underflow due to miscalculated used\_memory\_overhead ([#3005](valkey-io/valkey#3005)) - Avoid duplicate calculations of network-bytes-out in slot stats with copy-avoidance ([#3046](valkey-io/valkey#3046)) - Fix XREAD returning error on empty stream with + ID ([#2742](valkey-io/valkey#2742)) #### Performance/Efficiency Improvements - Track reply bytes in I/O threads if commandlog-reply-larger-than is -1 ([#3086](valkey-io/valkey#3086), [#3126](valkey-io/valkey#3126)). This makes it possible to mitigate a performance regression in 9.0.1 caused by the bug fix [#2652](valkey-io/valkey#2652). **Full Changelog**: <valkey-io/valkey@9.0.1...9.0.2> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - "before 6am" - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).

HSETEX - Aways issue keyspace notifications after validation

1f0337a

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

ranshid requested a review from madolson January 3, 2026 13:53

ranshid added this to Valkey 9.1 Jan 3, 2026

ranshid added the needs-doc-pr This change needs to update a documentation page. Remove label once doc PR is open. label Jan 3, 2026

github-actions Bot assigned ranshid Jan 3, 2026

Merge remote-tracking branch 'origin/unstable' into hsetex-always-rep…

beec125

…ort-keyspace-events Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

ranshid changed the title ~~HSETEX - Aways issue keyspace notifications after validation~~ HSETEX - Always issue keyspace notifications after validation Jan 4, 2026

ranshid marked this pull request as ready for review January 4, 2026 14:49

ranshid mentioned this pull request Jan 5, 2026

HFE make zero a valid ttl during import mode and data loading #3006

Merged

Alway return 1 in case the validations passed

35e3529

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

ranshid added major-decision-pending Major decision pending by TSC team and removed major-decision-pending Major decision pending by TSC team labels Jan 12, 2026

ranshid added this to Valkey 9.0 Jan 21, 2026

ranshid requested a review from murphyjacob4 January 21, 2026 11:41

murphyjacob4 reviewed Jan 24, 2026

View reviewed changes

Comment thread src/t_hash.c

murphyjacob4 approved these changes Jan 26, 2026

View reviewed changes

Comment thread tests/unit/hashexpire.tcl Outdated

Comment thread tests/unit/hashexpire.tcl

ranshid added 6 commits January 26, 2026 07:38

revive some deleted tests

2b00cdd

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

Merge remote-tracking branch 'origin/unstable' into hsetex-always-rep…

4648e52

…ort-keyspace-events

also revert dome conditional checks

5520c5e

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

fix Zero is a valid ttl

1a833d4

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

always perform lazy expiration in case of HSETEX

3023eb8

Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

Merge remote-tracking branch 'origin/unstable' into hsetex-always-rep…

33ef505

…ort-keyspace-events

ranshid mentioned this pull request Jan 28, 2026

deflake HSETEX EXAT single field expires leaving other fields intact #3120

Merged

madolson approved these changes Jan 29, 2026

View reviewed changes

Apply suggestions from code review

29091af

Co-authored-by: Jacob Murphy <jkmurphy@google.com> Signed-off-by: Ran Shidlansik <ranshid@amazon.com>

ranshid merged commit fd14380 into valkey-io:unstable Jan 29, 2026
23 of 24 checks passed

github-project-automation Bot moved this to To be backported in Valkey 9.0 Jan 29, 2026

github-project-automation Bot moved this to Done in Valkey 9.1 Jan 29, 2026

ranshid added the release-notes This issue should get a line item in the release notes label Jan 29, 2026

ranshid mentioned this pull request Jan 29, 2026

Backport more hfe fixes #3131

Closed

ranshid mentioned this pull request Jan 29, 2026

Backport more hfe fixes #3132

Merged

zuiderkwast moved this from To be backported to 9.0.2 WIP in Valkey 9.0 Jan 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HSETEX - Always issue keyspace notifications after validation#3001

HSETEX - Always issue keyspace notifications after validation#3001
ranshid merged 10 commits into
valkey-io:unstablefrom
ranshid:hsetex-always-report-keyspace-events

ranshid commented Jan 3, 2026 •

edited

Loading

Uh oh!

ranshid commented Jan 3, 2026

Uh oh!

codecov Bot commented Jan 3, 2026 •

edited

Loading

Uh oh!

madolson commented Jan 5, 2026

Uh oh!

ranshid commented Jan 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madolson left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ranshid commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ranshid commented Jan 3, 2026

Uh oh!

codecov Bot commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

madolson commented Jan 5, 2026

Uh oh!

ranshid commented Jan 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

madolson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ranshid commented Jan 3, 2026 •

edited

Loading

codecov Bot commented Jan 3, 2026 •

edited

Loading