Skip to content

HFE make zero a valid ttl during import mode and data loading #3006

Merged
ranshid merged 2 commits into
valkey-io:unstablefrom
cjx-zar:fix-zero-expiry-in-HFE
Jan 6, 2026
Merged

HFE make zero a valid ttl during import mode and data loading #3006
ranshid merged 2 commits into
valkey-io:unstablefrom
cjx-zar:fix-zero-expiry-in-HFE

Conversation

@cjx-zar

@cjx-zar cjx-zar commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

The HFE uses EXPIRY_NONE(-1) for fields without a TTL. A bug exists in HSETEX and RDB loading where expiry > 0 is used to check for an expiration. This is problematic because 0 might be treated as no expiry in import-mode, instead of an already expired timestamp, leading to incorrect behavior.

Signed-off-by: cjx-zar <jxchenczar@foxmail.com>
@cjx-zar cjx-zar force-pushed the fix-zero-expiry-in-HFE branch from 03dfb48 to bb3c851 Compare January 5, 2026 05:50
@codecov

codecov Bot commented Jan 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.34%. Comparing base (e4a3e9f) to head (6c84f99).
⚠️ Report is 6 commits behind head on unstable.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #3006   +/-   ##
=========================================
  Coverage     74.34%   74.34%           
=========================================
  Files           129      129           
  Lines         70908    70911    +3     
=========================================
+ Hits          52714    52718    +4     
+ Misses        18194    18193    -1     
Files with missing lines Coverage Δ
src/rdb.c 77.04% <100.00%> (-0.23%) ⬇️
src/t_hash.c 94.92% <100.00%> (ø)

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ranshid ranshid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should just move the test to hashexpire.tcl

Comment thread tests/unit/expire.tcl Outdated
@ranshid ranshid changed the title make zero a valid ttl in HFE HFE make zero a valid ttl during import mode and data loading Jan 5, 2026
@enjoy-binbin enjoy-binbin moved this to To be backported in Valkey 9.0 Jan 5, 2026
@ranshid ranshid added the bug Something isn't working label Jan 5, 2026
Signed-off-by: cjx-zar <jxchenczar@foxmail.com>
@ranshid ranshid added the release-notes This issue should get a line item in the release notes label Jan 5, 2026
@cjx-zar

cjx-zar commented Jan 5, 2026

Copy link
Copy Markdown
Contributor Author

By the way, I'd like to ask a question.
The documentation states that HSETEX returns "0 if none of the provided fields' values ​​and/or expiration times were set."
However, if the timestamp is expired, and the command contains duplicate fields(e.g.hsetex myhash ex 0 fields 2 f1 v1 f1 v2) or some fields that doesn't exist, the return value will also be 0.
This seems inconsistent with the description of "none of ... were set."
Also, the example in the documentation, HSETEX EX 0 myhash FIELDS 3 f1 v1 f2 v2 f3 v3, has a syntax error and should be corrected to HSETEX myhash EX 0 FIELDS 3 f1 v1 f2 v2 f3 v3

@ranshid

ranshid commented Jan 5, 2026

Copy link
Copy Markdown
Member

The documentation states that HSETEX returns "0 if none of the provided fields' values ​​and/or expiration times were set."
However, if the timestamp is expired, and the command contains duplicate fields(e.g.hsetex myhash ex 0 fields 2 f1 v1 f1 v2) or some fields that doesn't exist, the return value will also be 0.
This seems inconsistent with the description of "none of ... were set."

True. this is somewhat related to: #3001 since in the original implementation it was done as if to ignore these actions from ever being performed. However I agree that if we decide that we will report these keyspace events, we will probably have to report that in the result.

@ranshid ranshid merged commit 5a3fb04 into valkey-io:unstable Jan 6, 2026
57 checks passed
jdheyburn pushed a commit to jdheyburn/valkey that referenced this pull request Jan 8, 2026
…-io#3006)

The HFE uses EXPIRY_NONE(-1) for fields without a TTL. A bug exists in
`HSETEX` and RDB loading where `expiry > 0` is used to check for an
expiration. This is problematic because `0` might be treated as no
expiry in `import-mode`, instead of an already expired timestamp,
leading to incorrect behavior.

---------

Signed-off-by: cjx-zar <jxchenczar@foxmail.com>
zuiderkwast pushed a commit to zuiderkwast/valkey that referenced this pull request Jan 29, 2026
…-io#3006)

The HFE uses EXPIRY_NONE(-1) for fields without a TTL. A bug exists in
`HSETEX` and RDB loading where `expiry > 0` is used to check for an
expiration. This is problematic because `0` might be treated as no
expiry in `import-mode`, instead of an already expired timestamp,
leading to incorrect behavior.

---------

Signed-off-by: cjx-zar <jxchenczar@foxmail.com>
ranshid pushed a commit to ranshid/valkey that referenced this pull request Jan 29, 2026
…-io#3006)

The HFE uses EXPIRY_NONE(-1) for fields without a TTL. A bug exists in
`HSETEX` and RDB loading where `expiry > 0` is used to check for an
expiration. This is problematic because `0` might be treated as no
expiry in `import-mode`, instead of an already expired timestamp,
leading to incorrect behavior.

---------

Signed-off-by: cjx-zar <jxchenczar@foxmail.com>
@ranshid ranshid mentioned this pull request Jan 29, 2026
ranshid pushed a commit that referenced this pull request Jan 29, 2026
The HFE uses EXPIRY_NONE(-1) for fields without a TTL. A bug exists in
`HSETEX` and RDB loading where `expiry > 0` is used to check for an
expiration. This is problematic because `0` might be treated as no
expiry in `import-mode`, instead of an already expired timestamp,
leading to incorrect behavior.

---------

Signed-off-by: cjx-zar <jxchenczar@foxmail.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
@ranshid ranshid mentioned this pull request Jan 29, 2026
zuiderkwast pushed a commit that referenced this pull request Jan 30, 2026
The HFE uses EXPIRY_NONE(-1) for fields without a TTL. A bug exists in
`HSETEX` and RDB loading where `expiry > 0` is used to check for an
expiration. This is problematic because `0` might be treated as no
expiry in `import-mode`, instead of an already expired timestamp,
leading to incorrect behavior.

---------

Signed-off-by: cjx-zar <jxchenczar@foxmail.com>
Signed-off-by: Ran Shidlansik <ranshid@amazon.com>
@zuiderkwast zuiderkwast moved this from To be backported to 9.0.2 WIP in Valkey 9.0 Jan 30, 2026
hpatro pushed a commit to hpatro/valkey that referenced this pull request Mar 5, 2026
…-io#3006)

The HFE uses EXPIRY_NONE(-1) for fields without a TTL. A bug exists in
`HSETEX` and RDB loading where `expiry > 0` is used to check for an
expiration. This is problematic because `0` might be treated as no
expiry in `import-mode`, instead of an already expired timestamp,
leading to incorrect behavior.

---------

Signed-off-by: cjx-zar <jxchenczar@foxmail.com>
Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
lmagomes pushed a commit to lmagomes/home-services that referenced this pull request May 12, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [docker.io/valkey/valkey](https://github.com/valkey-io/valkey) | image | patch | `9.0.1` → `9.0.4` |

---

### Release Notes

<details>
<summary>valkey-io/valkey (docker.io/valkey/valkey)</summary>

### [`v9.0.4`](https://github.com/valkey-io/valkey/releases/tag/9.0.4)

[Compare Source](valkey-io/valkey@9.0.3...9.0.4)

Upgrade urgency SECURITY: This release includes security fixes we recommend you
apply as soon as possible.

##### Security fixes

- (CVE-2026-23479) Use-After-Free in unblock client flow
- (CVE-2026-25243) Invalid Memory Access in RESTORE command
- (CVE-2026-23631) Use-after-free when full sync occurs during a yielding Lua/function execution

### [`v9.0.3`](https://github.com/valkey-io/valkey/releases/tag/9.0.3)

[Compare Source](valkey-io/valkey@9.0.2...9.0.3)

##### Valkey 9.0.3

Upgrade urgency SECURITY: This release includes security fixes we recommend you
apply as soon as possible.

##### Security fixes

- (CVE-2025-67733) RESP Protocol Injection via Lua error\_reply
- (CVE-2026-21863) Remote DoS with malformed Valkey Cluster bus message
- (CVE-2026-27623) Reset request type after handling empty requests

##### Bug fixes

- Avoids crash during MODULE UNLOAD when ACL rules reference a module command and subcommand ([#&#8203;3160](valkey-io/valkey#3160))
- Fix server assert on ACL LOAD when current user loses permission to channels ([#&#8203;3182](valkey-io/valkey#3182))
- Fix bug causing no response flush sometimes when IO threads are busy ([#&#8203;3205](valkey-io/valkey#3205))

### [`v9.0.2`](https://github.com/valkey-io/valkey/releases/tag/9.0.2)

[Compare Source](valkey-io/valkey@9.0.1...9.0.2)

Upgrade urgency HIGH: There are critical bugs that may affect a subset of users.

#### Bug fixes

- Avoid memory leak of new argv when HEXPIRE commands target only non-exiting fields ([#&#8203;2973](valkey-io/valkey#2973))
- Fix HINCRBY and HINCRBYFLOAT to update volatile key tracking ([#&#8203;2974](valkey-io/valkey#2974))
- Avoid empty hash object when HSETEX added no fields ([#&#8203;2998](valkey-io/valkey#2998))
- Fix case-sensitive check for the FNX and FXX arguments in HSETEX ([#&#8203;3000](valkey-io/valkey#3000))
- Prevent assertion in active expiration job after a hash with volatile fields is overwritten ([#&#8203;3003](valkey-io/valkey#3003), [#&#8203;3007](valkey-io/valkey#3007))
- Fix HRANDFIELD to return null response when no field could be found ([#&#8203;3022](valkey-io/valkey#3022))
- Fix HEXPIRE to not delete items when validation rules fail and expiration is in the past ([#&#8203;3023](valkey-io/valkey#3023), [#&#8203;3048](valkey-io/valkey#3048))
- Fix how hash is handling overriding of expired fields overwrite ([#&#8203;3060](valkey-io/valkey#3060))
- HSETEX - Always issue keyspace notifications after validation ([#&#8203;3001](valkey-io/valkey#3001))
- Make zero a valid TTL for hash fields during import mode and data loading ([#&#8203;3006](valkey-io/valkey#3006))
- Trigger prepareCommand on argc change in module command filters ([#&#8203;2945](valkey-io/valkey#2945))
- Restrict TTL from being negative and avoid crash in import-mode ([#&#8203;2944](valkey-io/valkey#2944))
- Fix chained replica crash when doing dual channel replication ([#&#8203;2983](valkey-io/valkey#2983))
- Skip slot cache optimization for AOF client to prevent key duplication and data corruption ([#&#8203;3004](valkey-io/valkey#3004))
- Fix used\_memory\_dataset underflow due to miscalculated used\_memory\_overhead ([#&#8203;3005](valkey-io/valkey#3005))
- Avoid duplicate calculations of network-bytes-out in slot stats with copy-avoidance ([#&#8203;3046](valkey-io/valkey#3046))
- Fix XREAD returning error on empty stream with + ID ([#&#8203;2742](valkey-io/valkey#2742))

#### Performance/Efficiency Improvements

- Track reply bytes in I/O threads if commandlog-reply-larger-than is -1 ([#&#8203;3086](valkey-io/valkey#3086), [#&#8203;3126](valkey-io/valkey#3126)).
  This makes it possible to mitigate a performance regression in 9.0.1 caused by the bug fix [#&#8203;2652](valkey-io/valkey#2652).

**Full Changelog**: <valkey-io/valkey@9.0.1...9.0.2>

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - "before 6am"
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNjkuNCIsInVwZGF0ZWRJblZlciI6IjQzLjE2OS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working release-notes This issue should get a line item in the release notes

Projects

Status: 9.0.2
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants