Refactor V3Offsets creation
#552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titzer
reviewed
Jan 20, 2026
Owner
titzer
left a comment
titzer
left a comment
There was a problem hiding this comment.
Nice, I like this refactoring. Some small tweaks.
| var offsets = V3Offsets.new(); | ||
| masm.emit_v3_WasmFunction_decl_r_r(scratch, regs.func_arg); | ||
| asm.q.sub_m_i(G(scratch).plus(offsets.FuncDecl_tierup_trigger), FastIntTuning.entryTierUpDecrement); | ||
| asm.q.sub_m_i(G(scratch).plus(masm.getOffsets().FuncDecl_tierup_trigger), FastIntTuning.entryTierUpDecrement); |
Owner
There was a problem hiding this comment.
There is still an offsets field, correct? I think we should make the SPC uniformly use its own offsets field then.
Contributor
Author
There was a problem hiding this comment.
There isn't an offsets field in SPC anymore as I intended for the MacroAssembler to store/cache it. Should I also cache it in SPC?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up all creations of
V3Offsetsscattered around the x86 code and moves them intoTargetto prevent excessive creation ofV3Offsets(which causes aX86_64Stackcreation in its fields).