fix(ci): vendor Prism uploader + fix infra-smoke Prism upload#107
Merged
Conversation
The Prism step installed "prism-uploader @ git+.../analogdevicesinc/prism.git #subdirectory=scripts" and ran `python -m prism_client.upload_run` — but that repo doesn't exist, scripts/ has no packaging, and there is no prism_client module. The uploader is a standalone stdlib-only script (scripts/upload_run.py) in the *private* tfcollins/prism repo, so it can't be pip-installed or fetched anonymously. Vendor the two stdlib-only files verbatim into adi_lg_plugins/hw_ci/prism_upload (excluded from ruff; re-sync from source) and expose an adi-lg-prism-upload entry point. Rewrite infra-smoke's Prism step to run the vendored uploader from the installed package with the correct CLI (positional junit, --token via PRISM_TOKEN, --tag key=value). Validated end to end against a live Prism server. Claude-Session: https://claude.ai/code/session_01BuMAqiic68LrMr6wWC7NCe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the Prism upload step in
infra-smoke.yml, which never worked.Why
The step did:
Every part was wrong:
analogdevicesinc/prismdoesn't exist,scripts/has no packaging (so nothing topip install), there's noprism_clientmodule, and--labgrid-place/--leg/--git-shaaren't real flags. The real uploader is a standalone stdlib-only script (scripts/upload_run.py) in the privatetfcollins/prismrepo — so it can't be pip-installed or fetched anonymously. (This step is copied fromhw-request.yml, which has the same latent bug.)How
upload_run.py+_prism_client.pyverbatim intoadi_lg_plugins/hw_ci/prism_upload/(stdlib-only, ~554 lines). Excluded from ruff; re-sync from source if upstream changes.adi-lg-prism-uploadentry point.junit,--tokenviaPRISM_TOKEN,--project --auto-create-project --run-name, and--tag key=value(place/board/carrier/mode/git-sha). No pip-install, no private-repo fetch.Validation
Ran the vendored uploader against the live Prism server end to end: token auth succeeded, run uploaded (
status=pending, rc=0). Added a wiring test; fulltests/hw_ci/suite green (238), lint clean.Note
hw-request.yml/matlab-hw-request.ymlhave the same broken Prism step — a follow-up could switch them toadi-lg-prism-uploadtoo.https://claude.ai/code/session_01BuMAqiic68LrMr6wWC7NCe