fix(ci): point hw-request + matlab Prism upload at the vendored uploader#108
Merged
Conversation
Same broken Prism step as infra-smoke had: pip install of a nonexistent "prism-uploader @ .../analogdevicesinc/prism.git" + `python -m prism_client.upload_run` with nonexistent --labgrid-place/--leg flags. Switch the built-in path (the prism-upload-cmd escape hatch is unchanged) to the vendored adi_lg_plugins.hw_ci.prism_upload uploader with the correct CLI (positional junit, --token, --tag key=value). Add PRISM_CARRIER to matlab so its carrier tag is populated. Deprecated hw-matrix.yml is left untouched. Claude-Session: https://claude.ai/code/session_01BuMAqiic68LrMr6wWC7NCe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Applies the same Prism-upload fix (PR #107) to the two remaining active consumer workflows.
Why
hw-request.ymlandmatlab-hw-request.ymlcarry the identical broken Prism step —pip install "prism-uploader @ …/analogdevicesinc/prism.git#subdirectory=scripts"(repo doesn't exist / no packaging) +python -m prism_client.upload_run(no such module) with--labgrid-place/--legflags that don't exist. So Prism upload has never worked for these consumers either.How
adi_lg_plugins.hw_ci.prism_uploaduploader (added in fix(ci): vendor Prism uploader + fix infra-smoke Prism upload #107) with the correct CLI: positionaljunit,--token(fromPRISM_API_TOKEN),--auto-create-project --run-name, and--tag key=value(place/board/carrier/leg/git-sha).prism-upload-cmdescape hatch and allPRISM_*env vars are unchanged (contract preserved). AddedPRISM_CARRIERto matlab so its carrier tag is populated.hw-matrix.ymlleft untouched.Non-fatal step (
continue-on-error); validated uploader against a live Prism server in #107. YAML parses, guard test green.https://claude.ai/code/session_01BuMAqiic68LrMr6wWC7NCe