perf(queue): optimize syncAllSlots to batch sends and deduplicate DB queries#519
Open
garrappachc wants to merge 1 commit intomasterfrom
Open
perf(queue): optimize syncAllSlots to batch sends and deduplicate DB queries#519garrappachc wants to merge 1 commit intomasterfrom
garrappachc wants to merge 1 commit intomasterfrom
Conversation
…queries Batch all queue slot renders into a single gateway.send call instead of one per slot, and fetch actor player data once per send invocation passing it as actorPlayer prop to QueueSlot to avoid redundant DB queries. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gateway.sendcall instead of one call per slot, reducing gateway iterations from N to 1actorPlayerprop toQueueSlot, eliminating redundant DB queries (was querying once per slot per connected player)actorPlayeroptional prop toQueueSlotcomponent with'actorPlayer' in propsguard to skip the DB lookup when data is pre-fetchedTest plan
pnpm testpasses (newsync-clients.test.tsverifiesgateway.sendcalled once for all slots)pnpm lintpasses🤖 Generated with Claude Code