Skip to content

fix: ensure lazy types are loaded before reading version in save() paths #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stack72 merged 1 commit into from
Apr 13, 2026
Merged

fix: ensure lazy types are loaded before reading version in save() paths #1169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/infrastructure/persistence/yaml_definition_repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ export class YamlDefinitionRepository implements DefinitionRepository {
const data = definition.toData();
// Ensure type metadata is always present in persisted YAML
data.type = type.normalized;
await modelRegistry.ensureTypeLoaded(type);
const modelDef = modelRegistry.get(type);
data.typeVersion = modelDef?.version ?? data.typeVersion;
// Remove undefined values since YAML can't stringify them
Expand Down
1 change: 1 addition & 0 deletions src/infrastructure/persistence/yaml_evaluated_definition_repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ export class YamlEvaluatedDefinitionRepository {
const data = definition.toData();
// Ensure type metadata is always present in persisted YAML
data.type = type.normalized;
await modelRegistry.ensureTypeLoaded(type);
const modelDef = modelRegistry.get(type);
data.typeVersion = modelDef?.version ?? data.typeVersion;
// Remove undefined values since YAML can't stringify them
Expand Down
Loading