fix: ensure lazy types are loaded before reading version in save() paths

[stack72]

Summary

• Add await modelRegistry.ensureTypeLoaded(type) before modelRegistry.get(type) in YamlDefinitionRepository.save() and YamlEvaluatedDefinitionRepository.save()
• Without this, lazy-registered types (catalog-known but not yet imported) cause get() to return undefined, silently persisting a stale typeVersion to disk
• Follows the established fix pattern from libswamp/models/get.ts:76 and validation_service.ts:706

Closes swamp-club#90 (follow-up to swamp-club#89)

Test Plan

• deno check passes
• deno lint passes
• deno fmt --check passes
• All 4305 tests pass
• Filed systeminit/swamp-uat#136 for missing UAT coverage of typeVersion persistence

🤖 Generated with Claude Code

[github-actions]

Code Review

Clean, well-scoped bug fix that follows the established ensureTypeLoaded → get pattern used throughout the codebase (e.g., libswamp/models/get.ts:76, validation_service.ts, datastores/sync.ts:71, etc.).

Blocking Issues

None.

Suggestions

1. The existing yaml_definition_repository_test.ts doesn't cover the lazy-type typeVersion persistence path. The PR body mentions filing systeminit/swamp-uat#136 for UAT coverage, which is a reasonable approach — but a unit test asserting that save() with a lazy-registered type correctly resolves typeVersion (rather than falling back to stale data) would make this fix regression-proof at the unit level. Not blocking since the fix follows a well-tested pattern and the UAT tracking is in place.

Notes

• DDD: Infrastructure repositories correctly depend on the domain modelRegistry — layer direction is sound.
• Import boundary: Both files import from ../../domain/models/model.ts (domain internals), which is appropriate for infrastructure code. No libswamp boundary violation.
• No any types, license headers present, change is minimal and focused.
• ensureTypeLoaded accepts string | ModelType and the call sites pass ModelType — type-safe.

[github-actions]

Adversarial Review

Critical / High

None.

Medium

None.

Low

None.

Verdict

PASS — This is a clean, minimal 2-line fix that adds await modelRegistry.ensureTypeLoaded(type) before modelRegistry.get(type) in both YamlDefinitionRepository.save() and YamlEvaluatedDefinitionRepository.save(). It follows the established pattern from libswamp/models/get.ts:76 and validation_service.ts:706. The ensureTypeLoaded call is correctly placed after data.type assignment but before modelRegistry.get() and well before atomicWriteTextFile, so a loader failure propagates cleanly without leaving partial writes. Both files already import modelRegistry, the type parameter is ModelType which matches the string | ModelType signature, and the existing ?.version ?? data.typeVersion fallback handles the (now unlikely) undefined case. No new failure modes, no API contract changes, no concurrency concerns beyond the already-deduplicated loader promises.