Skip to content

[Android] Make FILE import as OpaquePointer on all APIs#88751

Merged
finagolfin merged 2 commits into
swiftlang:mainfrom
madsodgaard:android-file-pointer-opaque
May 3, 2026
Merged

[Android] Make FILE import as OpaquePointer on all APIs#88751
finagolfin merged 2 commits into
swiftlang:mainfrom
madsodgaard:android-file-pointer-opaque

Conversation

@madsodgaard

@madsodgaard madsodgaard commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Depends on #88714

  • Explanation: Adds a API note to the Android module to make FILE import as OpaquePointer on API 23. This needed to make the official Android SDK support API 23.
  • Scope: Limited to Android, only a breaking change if you were only building for API 23 and explicitly typing the FILE pointer as UnsafeMutablePointer<FILE>.
  • Issues:
  • Risk: Again, limited to Android and only makes a difference on API 23.
  • Testing: Adds an Android test to verify the behaviour

@madsodgaard madsodgaard requested a review from a team as a code owner April 30, 2026 13:17
@finagolfin

Copy link
Copy Markdown
Member

@madsodgaard, add the change log entry for the underlying compiler pull as a second commit here and we'll get this in.

@compnerd, please review.

@madsodgaard madsodgaard force-pushed the android-file-pointer-opaque branch from 22914a1 to 40bc32e Compare May 2, 2026 09:59
@finagolfin

Copy link
Copy Markdown
Member

@swift-ci test

@finagolfin

Copy link
Copy Markdown
Member

@swift-ci test android

@madsodgaard madsodgaard force-pushed the android-file-pointer-opaque branch from 40bc32e to a16546c Compare May 2, 2026 10:05
@finagolfin

Copy link
Copy Markdown
Member

@swift-ci test

@finagolfin

Copy link
Copy Markdown
Member

@swift-ci test android

Comment thread test/ClangImporter/android-file-pointer-opaque.swift Outdated
@finagolfin

Copy link
Copy Markdown
Member

@swift-ci test android

@finagolfin

Copy link
Copy Markdown
Member

Check if the Docker pull works with cross-repo testing yet.

swiftlang/swift-docker#536

@swift-ci test android

@finagolfin

Copy link
Copy Markdown
Member

Looks like the Docker commit wasn't checked out, so that last cross-repo CI run is useless.

@madsodgaard madsodgaard force-pushed the android-file-pointer-opaque branch from c65fb37 to 13b4a25 Compare May 3, 2026 09:51
@finagolfin

Copy link
Copy Markdown
Member

@swift-ci smoke test

@finagolfin

Copy link
Copy Markdown
Member

@swift-ci test android

@finagolfin finagolfin merged commit 8a1f8d7 into swiftlang:main May 3, 2026
3 of 4 checks passed
finagolfin added a commit to finagolfin/swift that referenced this pull request Jun 2, 2026
The new API note was added in swiftlang#88751 as part of the stdlib/ config.
finagolfin added a commit that referenced this pull request Jun 2, 2026
…#89599)

The new API note was added in #88751 as part of the stdlib/ config.
finagolfin added a commit that referenced this pull request Jun 3, 2026
…onfig (#89599) (#89634)

The new API note was added in #88751 as part of the stdlib/ config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants