swift-inspect: repair build for Android#89536
Closed
compnerd wants to merge 1 commit into
Closed
Conversation
Android now imports `FILE` as a typed pointer rather than an `OpaquePointer`. Remove the conditional typealias.
Member
Author
|
CC: @madsodgaard |
Member
Author
|
@swift-ci please smoke test |
Contributor
|
Hm this does not actually seem right. The changes we did with API notes should mean that |
Member
Author
|
Then the APINotes are not always being loaded. |
Member
|
Where do you see this failure exactly? The Windows trunk snapshot toolchain CI cross-compiles Is it possible that whatever CI you are testing on is not pulling in the Android API notes properly? |
finagolfin
requested changes
May 29, 2026
finagolfin
left a comment
finagolfin
left a comment
Member
There was a problem hiding this comment.
This will break other Android API levels and is likely incorrect.
Member
|
OK, I may have tracked this down: it looks like the Windows installer lists each Android API note separately, unlike |
Member
Author
That is certainly an issue that should've been tested before @madsodgaard's patch was merged (I didn't get around to reviewing the change before it was merged). However, that is a distribution issue, the build that occurs here is prior to the packaged version and is done from the staged build. |
Member
|
How does your build differ from the current trunk Windows snapshot toolchain CI, which always cross-compiles |
Member
Author
|
I'll get the exact invocation once the build is repaired - seems that something was committed that broken the early builds resulting in not being able to build at all currently. |
Member
|
Probably fixed by #89599 instead |
Member
Author
|
Yes, verified that it has been fixed. Thanks @finagolfin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android now imports
FILEas a typed pointer rather than anOpaquePointer. Remove the conditional typealias.