build: Remove --test-wasm-stdlib option
#86144
Merged
+2
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci smoke test |
kateinoigakukun
force-pushed
the
yt/remove-test-wasm-stdlib
branch
from
74a02c6 to
8ee7942
Compare
We already adopted wasi-libc 27, which includes the necessary fix for null builds, so we no longer need a way to run wasm tests without building. Also removing the logic that unintentionally enforced `--test-wasm-stdlib` whenever `--build-wasm-stdlib` was specified.
kateinoigakukun
force-pushed
the
yt/remove-test-wasm-stdlib
branch
from
8ee7942 to
6bdf676
Compare
Member
Author
|
@swift-ci smoke test |
Member
Author
|
@swift-ci smoke test Windows platform |
kateinoigakukun
requested review from
edymtt,
etcwilde,
justice-adams-apple and
shahmishal
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already adopted wasi-libc 27, which includes the necessary fix for null builds, so we no longer need a way to run wasm tests without building. Also removing the logic that unintentionally enforced
--test-wasm-stdlibwhenever--build-wasm-stdlibwas specified.