Skip to content

Commit c70440f

Browse files
Merge pull request #86144 from kateinoigakukun/yt/remove-test-wasm-stdlib
build: Remove `--test-wasm-stdlib` option
2 parents 5c2f51e + 6bdf676 commit c70440f

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

utils/build_swift/build_swift/driver_arguments.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -295,9 +295,6 @@ def _apply_default_arguments(args):
295295
args.test_xros_host = False
296296
args.test_android_host = False
297297

298-
if args.build_wasmstdlib:
299-
args.test_wasmstdlib = True
300-
301298

302299
def create_argument_parser():
303300
"""Return a configured argument parser."""
@@ -862,8 +859,6 @@ def create_argument_parser():
862859
option(['--build-wasm-stdlib'], toggle_true('build_wasmstdlib'),
863860
help='build the stdlib for WebAssembly target into a'
864861
'separate build directory ')
865-
option('--test-wasm-stdlib', toggle_true('test_wasmstdlib'),
866-
help='test stdlib for WebAssembly')
867862
option(['--wasmkit'], toggle_true('build_wasmkit'),
868863
help='build WasmKit')
869864
option(['--install-wasmkit'], toggle_true('install_wasmkit'),

utils/build_swift/tests/expected_options.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,7 @@
342342
'test_swiftformat': False,
343343
'test_swiftdocc': False,
344344
'test_toolchainbenchmarks': False,
345-
'test_wasmstdlib': False,
345+
'test_wasmstdlib': True,
346346
'tvos': False,
347347
'tvos_all': False,
348348
'validation_test': None,
@@ -607,7 +607,6 @@ class BuildScriptImplOption(_BaseOption):
607607
SetTrueOption('--swiftdocc', dest='build_swiftdocc'),
608608
SetTrueOption('--build-minimal-stdlib', dest='build_minimalstdlib'),
609609
SetTrueOption('--build-wasm-stdlib', dest='build_wasmstdlib'),
610-
SetTrueOption('--test-wasm-stdlib', dest='test_wasmstdlib'),
611610
SetTrueOption('--wasmkit', dest='build_wasmkit'),
612611
SetTrueOption('--build-stdlib-docs'),
613612
SetTrueOption('--preview-stdlib-docs'),

utils/swift_build_support/swift_build_support/build_script_invocation.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -685,9 +685,7 @@ def compute_product_pipelines(self):
685685
builder.add_product(products.WasmKit,
686686
is_enabled=self.args.build_wasmkit)
687687
builder.add_product(products.WasmStdlib,
688-
# Revert `or self.args.test_wasmstdlib` once we adopt `wasi-sdk-26`
689-
# or higher version that includes https://github.com/WebAssembly/wasi-libc/commit/eadb436d5c09f7983c3a687086e5af6b6e9f5510.patch
690-
is_enabled=self.args.build_wasmstdlib or self.args.test_wasmstdlib)
688+
is_enabled=self.args.build_wasmstdlib)
691689
builder.add_product(products.WasmThreadsStdlib,
692690
is_enabled=self.args.build_wasmstdlib)
693691
builder.add_product(products.WasmSwiftSDK,

0 commit comments

Comments
 (0)