-
Notifications
You must be signed in to change notification settings - Fork 0
[SIP-00008] - Support personal_sign Authorization for EIP-7702
#10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kingster-will
wants to merge
4
commits into
main
Choose a base branch
from
sip-00008
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| --- | ||
| number: '00008' | ||
| title: Support personal_sign for EIP-7702 | ||
| authors: Kingter Wang (kingter@piplabs.xyz) | ||
| sponsors: Leo Chen (leo@piplabs.xyz) | ||
| created: 2025-12-22 | ||
| type: Standard | ||
| status: Accepted | ||
| supersedes: | ||
| superseded-by: | ||
| extends: | ||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| This SIP formalizes support on the Story chain for EIP-7702 authorization | ||
| signatures produced via `personal_sign`. | ||
|
|
||
| The change expands wallet compatibility for EIP-7702 type `0x04` transactions | ||
| while preserving the existing authorization semantics and security guarantees. | ||
|
|
||
|
|
||
| [forum discussion link](https://forum.story.foundation/t/proposal-support-personal-sign-for-eip-7702-authorization-signatures/37328) | ||
|
|
||
| ## Motivation | ||
|
|
||
| EIP-7702 relies on off-chain authorization signatures to enable delegated | ||
| execution. | ||
|
|
||
| In practice, many widely used wallets—especially modern browser wallets—do | ||
| not support `eth_sign`, but do support `personal_sign`. Without accepting | ||
| `personal_sign`-based authorizations, these wallets cannot participate in | ||
| EIP-7702 flows on Story. | ||
|
|
||
| This SIP ensures that EIP-7702 remains usable with real-world wallet | ||
| infrastructure. | ||
|
|
||
| ## Proposal | ||
|
|
||
| The Story execution client SHOULD accept EIP-7702 authorization signatures | ||
| generated via `personal_sign`. | ||
|
|
||
| Such signatures MUST represent a canonical, human-readable authorization | ||
| message that unambiguously binds: | ||
|
|
||
| - the chain ID | ||
| - the authorized implementation address | ||
| - the authorization nonce | ||
|
|
||
| The execution client MUST treat `personal_sign` and `eth_sign` authorizations | ||
| as semantically equivalent once verified. | ||
|
|
||
| Transactions containing `personal_sign` authorizations MUST include an explicit | ||
| signaling | ||
| mechanism allowing the execution client to distinguish the signature type | ||
| during verification. | ||
|
|
||
|
|
||
| ### Drawbacks | ||
|
|
||
| N/A | ||
|
|
||
| ### Alternatives Considered | ||
|
|
||
| N/A | ||
kingster-will marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ### User Impact | ||
|
|
||
| - Enables EIP-7702 usage for modern browser wallets | ||
| - Improves onboarding and developer experience | ||
| - Requires no changes to user transaction flows | ||
| - Does not affect existing users or transactions | ||
|
|
||
| ## Implementation Considerations | ||
|
|
||
| - The change is limited to authorization verification logic in the execution client | ||
| - No changes to transaction structure or consensus rules | ||
| - Backward compatibility is preserved | ||
| - Message construction details are considered implementation-specific | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is safer to be more opinionated in this standard, or people can be tricked into delegation by signing wrong or unrelated messages.
Strongly suggest using our already implemented pattern
https://github.com/piplabs/story-geth/blob/main/core/types/tx_setcode.go#L123-L135