Skip to content

[SIP-00008] - Support personal_sign Authorization for EIP-7702#10

Open
kingster-will wants to merge 4 commits intomainfrom
sip-00008
Open

[SIP-00008] - Support personal_sign Authorization for EIP-7702#10
kingster-will wants to merge 4 commits intomainfrom
sip-00008

Conversation

@kingster-will
Copy link

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces SIP-00008, which proposes adding support for personal_sign authorization signatures in EIP-7702 transactions on the Story blockchain. The proposal aims to expand wallet compatibility by allowing modern browser wallets that support personal_sign (but not eth_sign) to participate in EIP-7702 delegated execution flows.

Key changes:

  • Defines requirements for accepting personal_sign-based EIP-7702 authorization signatures
  • Specifies that such signatures must bind chain ID, authorized implementation address, and authorization nonce
  • Mandates semantic equivalence between personal_sign and eth_sign authorizations after verification

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

as semantically equivalent once verified.

Transactions containing `personal_sign` authorizations MUST include an explicit
signaling
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is safer to be more opinionated in this standard, or people can be tricked into delegation by signing wrong or unrelated messages.

Strongly suggest using our already implemented pattern
https://github.com/piplabs/story-geth/blob/main/core/types/tx_setcode.go#L123-L135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants