test: document intentional error tolerance in MaxOutputBytes unlimited subtest#29
Closed
Copilot wants to merge 3 commits into
Closed
Conversation
… limits Add a MaxOutputBytes field to DecodeOptions that tracks cumulative decoded output size across a single decode operation. Before each allocation (array element, union arm, optional field, opaque data), the size is added to a running total; if it exceeds MaxOutputBytes the decode is aborted with ErrOutputBytesExceeded. Key changes: - Add TrackOutputBytes method and TrackOutputBytesOf[T] generic helper - Cap array pre-allocation at 256 elements, growing via append beyond that - Track allocations in DecodeFixedOpaque, decodeArray, decodeUnion, decodeMap, and allocPtrIfNil - Bump minimum Go version to 1.25 for generics support Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
Co-authored-by: tamirms <1445829+tamirms@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Work in progress to address feedback on MaxOutputBytes decode
test: document intentional error tolerance in MaxOutputBytes unlimited subtest
Mar 11, 2026
tamirms
force-pushed
the
reduce-allocations
branch
from
112f917 to
c677e1b
Compare
|
Closing — improvements from this PR have been incorporated into #22 where applicable. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reviewer flagged that the
"unlimited"subtest inTestMaxOutputBytesignores the error fromUnmarshalWithOptions, suggesting it should asserterr == nil. The test's intent is actually the opposite: the crafted payload uses an oversized array header that will hit EOF before all declared elements are read, so an error is expected. The test only verifies the decoder doesn't reject the input outright or decode zero elements.Changes
xdr3/decode_limits_test.go: Added an inline comment to the"unlimited"subtest explaining thaterris intentionally not checked — EOF is expected from the oversized header, and the assertion only guards against zero-element output.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.