docs: add Rust agent guidance#15
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive set of Rust coding, testing, and side-effect guidelines in modules/rust.md, and updates modules/engineering.md to advise against using boolean fields for growing states. The review feedback correctly identifies a contradiction in the Rust guidelines regarding enums and boolean options, suggesting an update to align with the general engineering guidelines and prevent boolean blindness.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eebb10aa9b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Run `cargo dylint --workspace --all` after Clippy when the repo has | ||
| `dylint.toml`. |
There was a problem hiding this comment.
Run Dylint with all targets and features
In Rust workspaces that put stella Dylint checks on tests, examples, or feature-gated code, this narrower command only runs through cargo check defaults, while the baseline Clippy gate above explicitly covers --all-targets --all-features. Dylint accepts Cargo check args after -- (its docs show cargo dylint --all -- --all-targets ...), so this shared guidance should mirror the same target/feature coverage; otherwise CI can pass while custom lints never inspect those code paths.
Useful? React with 👍 / 👎.
Summary