Skip to content

docs: add Rust agent guidance#15

Open
jan-kubica wants to merge 3 commits into
mainfrom
feat/rust-agent-guidance
Open

docs: add Rust agent guidance#15
jan-kubica wants to merge 3 commits into
mainfrom
feat/rust-agent-guidance

Conversation

@jan-kubica

Copy link
Copy Markdown
Contributor

Summary

  • add shared Rust agent guidance for strict workspace lints, Dylint, Bon builders, artifacts, and parity testing
  • add a shared modeling guideline for avoiding boolean flags where a named state/domain type is more durable

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a comprehensive set of Rust coding, testing, and side-effect guidelines in modules/rust.md, and updates modules/engineering.md to advise against using boolean fields for growing states. The review feedback correctly identifies a contradiction in the Rust guidelines regarding enums and boolean options, suggesting an update to align with the general engineering guidelines and prevent boolean blindness.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread modules/rust.md Outdated
@jan-kubica jan-kubica marked this pull request as ready for review June 27, 2026 05:21

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eebb10aa9b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread modules/rust.md
Comment on lines +13 to +14
Run `cargo dylint --workspace --all` after Clippy when the repo has
`dylint.toml`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Run Dylint with all targets and features

In Rust workspaces that put stella Dylint checks on tests, examples, or feature-gated code, this narrower command only runs through cargo check defaults, while the baseline Clippy gate above explicitly covers --all-targets --all-features. Dylint accepts Cargo check args after -- (its docs show cargo dylint --all -- --all-targets ...), so this shared guidance should mirror the same target/feature coverage; otherwise CI can pass while custom lints never inspect those code paths.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant