Skip to content

[6.x] Truncate full measure static cache files before writing #14755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 3 commits into from
Jun 2, 2026
+58 −0
Merged

[6.x] Truncate full measure static cache files before writing #14755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a1cf0a
Truncate static cache files before writing
joshuablum Jun 1, 2026
aaf7aca
Add test
joshuablum Jun 1, 2026
4c4fef7
Handle ftruncate failure and clean up test directory in tearDown
jasonvarga Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/StaticCaching/Cachers/Writer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,15 @@ public function write($path, $content, $lockFor = 0)
return false;
}

// Truncate the file before writing. Since the "c" mode doesn't truncate and leaves
// the pointer at the start, writing content shorter than what's already on disk
// would otherwise leave stale bytes behind, producing an invalid document.
if (! ftruncate($handle, 0)) {
fclose($handle);

return false;
}

fwrite($handle, $content);
chmod($path, $this->permissions['file']);

Expand Down
49 changes: 49 additions & 0 deletions tests/StaticCaching/WriterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
<?php

namespace Tests\StaticCaching;

use PHPUnit\Framework\Attributes\Test;
use Statamic\StaticCaching\Cachers\Writer;
use Tests\TestCase;

class WriterTest extends TestCase
{
private string $path;

public function setUp(): void
{
parent::setUp();

$this->path = storage_path('framework/testing/static-cache-writer/page.html');

@unlink($this->path);
}

public function tearDown(): void
{
@unlink($this->path);
@rmdir(dirname($this->path));

parent::tearDown();
}

#[Test]
public function it_writes_the_content_to_disk()
{
$written = (new Writer)->write($this->path, '<html>hello</html>');

$this->assertTrue($written);
$this->assertSame('<html>hello</html>', file_get_contents($this->path));
}

#[Test]
public function it_truncates_stale_bytes_when_overwriting_with_shorter_content()
{
$writer = new Writer;

$writer->write($this->path, '<html>this is a much longer page</html>');
$writer->write($this->path, '<html>short</html>');

$this->assertSame('<html>short</html>', file_get_contents($this->path));
}
}
Loading