[6.x] Truncate full measure static cache files before writing#14755
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jasonvarga
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, full measure static cache operations open cache files with
fopen($path, 'c')and thenfwrites the content. Modecpositions the pointer at the start of the file but does not truncate it. When a page is recached with content shorter than the version already on disk, the leftover bytes past the new content are still there producing a valid document followed by leftovers after the</html>.Having
background_recacheenabled, saving an entry overwrites the file in place rather than deleting it, so any edit that shrinks a page leaves bits behind.This fixes it by calling
ftruncate($handle, 0)after acquiring the lock and before writing. Modeckeeps the pointer at byte 0 after truncation.Closes #14742.