Skip to content

ordering_service: normalize ip identifiers #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sorah merged 1 commit into from
Apr 6, 2026
+2 −2
Merged

ordering_service: normalize ip identifiers #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/acmesmith/ordering_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ def acme_identifier(name)
end

begin
IPAddr.new(name) # Test if it parses
{ type: 'ip', value: name }
addr = IPAddr.new(name)
{ type: 'ip', value: addr.to_s } # IPAddr#to_s normalizes IPv6 address to RFC 5952 form as required by RFC 8738 \S 3
rescue IPAddr::InvalidAddressError
{ type: 'dns', value: name }
end
Expand Down