ordering_service: normalize ip identifiers#85
Merged
Conversation
RFC 8738 requires IPv6 identifiers to follow the textual form defined in RFC 5952 §4 (lowercase hex, compressed). The raw input string was previously sent as-is to the CA. This causes renewal to fail when a certificate was previously issued with an IPv6 SAN: OpenSSL renders IPv6 addresses with uppercase hex digits, so when acmesmith reads the existing certificate's SANs to build the renewal order, the uppercase form is passed through unchanged and rejected by the CA as a malformed identifier. Fixup: sorah#83
Contributor
Author
|
It seems pebble does not enforce the address format requirement. |
sorah
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 8738 requires IPv6 identifiers to follow the textual form defined in RFC 5952 §4 (lowercase hex, compressed). The raw input string was previously sent as-is to the CA.
This causes renewal to fail when a certificate was previously issued with an IPv6 SAN: OpenSSL renders IPv6 addresses with uppercase hex digits, so when acmesmith reads the existing certificate's SANs to build the renewal order, the uppercase form is passed through unchanged and rejected by the CA as a malformed identifier.
Fixup: #83