Skip to content

feat: add software deployment cache as item for shared fs usage#99

Merged
johanneskoester merged 3 commits intomainfrom
feat/shared-fs-deployment-cache
Mar 8, 2026
Merged

feat: add software deployment cache as item for shared fs usage#99
johanneskoester merged 3 commits intomainfrom
feat/shared-fs-deployment-cache

Conversation

@johanneskoester
Copy link
Contributor

@johanneskoester johanneskoester commented Mar 8, 2026

Summary by CodeRabbit

  • New Features
    • Added support for software deployment cache as a new shared filesystem usage configuration option, extending cache management capabilities for executor environments.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 8, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • pyproject.toml is excluded by !pyproject.toml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 611407ae-50b5-41bb-882d-8db8efc913e5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Added a new enum member SOFTWARE_DEPLOYMENT_CACHE with value 6 to the SharedFSUsage class, and updated the assume_common_workdir logic to include this new enum value in the common-usage check alongside existing members.

Changes

Cohort / File(s) Summary
Enum Extension & Conditional Update
snakemake_interface_executor_plugins/settings.py
Added SOFTWARE_DEPLOYMENT_CACHE = 6 enum member to SharedFSUsage and updated assume_common_workdir property logic to include this new enum value in the consideration set for common workdir usage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding SOFTWARE_DEPLOYMENT_CACHE as a new enum member to SharedFSUsage for shared filesystem usage consideration.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/shared-fs-deployment-cache

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@johanneskoester johanneskoester merged commit 899de94 into main Mar 8, 2026
3 checks passed
@johanneskoester johanneskoester deleted the feat/shared-fs-deployment-cache branch March 8, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant