Skip to content

Fixes for PR #96#170

Merged
void2012 merged 6 commits intosmartcmd:mainfrom
lspepinho:main
Mar 2, 2026
Merged

Fixes for PR #96#170
void2012 merged 6 commits intosmartcmd:mainfrom
lspepinho:main

Conversation

@lspepinho
Copy link
Contributor

Pull Request

This PR just fixes PR #96. Nothing TOO crazy

@void2012
Copy link
Collaborator

void2012 commented Mar 2, 2026

Is this still being worked on? Should I convert to draft?

@simulpingus
Copy link
Contributor

thanks for fixing
it looks good to me

@lspepinho
Copy link
Contributor Author

lspepinho commented Mar 2, 2026

Is this still being worked on? Should I convert to draft?

Nope, I just fixed merge conflicts. Should be good now for merging.

@void2012
Copy link
Collaborator

void2012 commented Mar 2, 2026

Is this based on that multiplayer fork or it its own effort?

@lspepinho
Copy link
Contributor Author

Is this based on that multiplayer fork or it its own effort?

That one fork

@simulpingus
Copy link
Contributor

it's a little modified based off the other fork

@void2012
Copy link
Collaborator

void2012 commented Mar 2, 2026

Have you tested it? Does it work good? Please attach a gameplay footage and update readme.md

@lspepinho
Copy link
Contributor Author

It works, ill update the README rq

2026-03-02.17-25-42.online-video-cutter.com.mp4

@void2012 void2012 added enhancement New feature or request priority: low multiplayer Multiplayer, CO-OP, Hot Seat, call it whatever you want. labels Mar 2, 2026
@lspepinho
Copy link
Contributor Author

Updated the README

Copy link

@UlisesMilles UlisesMilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested for a while and it works, I just commented for the sake of it, tbh, but there's not any apparent problem with it

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments should not be removed, even though the comments on those lines seemed not that important. (a lot of irrelevant changes are made to this document, it is working ok, and that's what matters)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not remove Debug console printf's. (again, a lot of unnecessary changes are made to this file)

@lspepinho
Copy link
Contributor Author

@simulpingus Gave you commit perms on my repo if you want to commit something

@lspepinho
Copy link
Contributor Author

Solved merge conflicts yet again lol

@void2012
Copy link
Collaborator

void2012 commented Mar 2, 2026

How does it work now? Attach a gameplay video

@lspepinho
Copy link
Contributor Author

How does it work now? Attach a gameplay video

Already attached one up there

@void2012 void2012 merged commit 8b28c20 into smartcmd:main Mar 2, 2026
@lspepinho lspepinho deleted the main branch March 3, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request multiplayer Multiplayer, CO-OP, Hot Seat, call it whatever you want. priority: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants