Add implement Multiplayer System (LAN Host/Join + Target Server)#179
Open
kuwacom wants to merge 5 commits intosmartcmd:mainfrom
Open
Add implement Multiplayer System (LAN Host/Join + Target Server)#179kuwacom wants to merge 5 commits intosmartcmd:mainfrom
kuwacom wants to merge 5 commits intosmartcmd:mainfrom
Conversation
- Implement Windows64 LAN multiplayer (host/join, discovery, session flow) - Add command-line options for multiplayer testing: -name, -host, -target - Add multiplayer usage docs to README - Reference implementation: https://github.com/LCEMP/LCEMP
…terrain load speed - Add SystemFlagClearForSystem (PlatformNetworkManagerInterface / GameNetworkManager) - In PlayerList::placeNewPlayer, clear flags when no active player exists on the same system - Prevent initial chunk transmission from being incorrectly skipped after disconnect/reconnect
# Conflicts: # Minecraft.Client/Minecraft.Client.vcxproj.filters
Contributor
Contributor
|
What does this PR add compared to Simul's? |
Author
|
Oh, I didn't there was already one like that. I haven't checked that one yet, so I'll give it a try. |
Author
It looked almost the same to me. There might be other differences in display, connectivity, or specific bugs. |
Contributor
|
They are based on the same fork, so its the same bugs. @kuwacom |
Owner
|
Close this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Multiplayer System (LAN Host/Join + Target Server)
Description
This PR implements a Windows64 Multiplayer System, including LAN host/join flow, target-server join support, and reconnect stability improvements.
Changes
New Behavior
-target <IP:PORT>.Previous Behavior
After reconnecting, chunk loading could become very slow or appear stuck.
Cause
Per-system chunk-sent flags were not cleared on reconnect, leaving stale streaming state.
Fix Implementation
WinsockNetLayer) for host/join transport.-name <PlayerName>-host <IP:PORT>: default0.0.0.0:25565-target <IP:PORT>: default255.255.255.255:25565Acknowledgements
Special thanks to LCEMP/LCEMP.
This implementation was heavily based on the following repository:
Related Issues