Draft
Conversation
Collaborator
|
I assume 4JLibs folks are working on it, right? |
void2012
added
enhancement
Contributor
Author
|
This functionality is not part of the 4JLibs, it's a tool developed specifically for this game that didn't get leaked. |
Owner
|
lgtm! |
Contributor
Author
|
This problem can be solved by a work around, which we could do by exporting the translations (stringsGeneric.xml) in their original format and parsing them with the XML library that I believe is already included in the repository. Other way would be just recreating their tool. This would be for another PR. |
Collaborator
@smartcmd this is still WIP, FYI. |
Collaborator
|
Also, we now require manual tests and gameplay footage(until we develop unified automated tests) |
Contributor
Author
|
I created a issue for this. #138 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Note:
This PR cannot currently be merged because the required localization compilation tools are missing. Previously, 4J used a tool to compile all localized strings from every language into a single file (
languages.loc) withinMediaWindows64.arc. Once a fix is found, I will revisit and rework this PR.Description
Restores Java Achievements from 4J commented code