Skip to content

[codex] Make indicator test helper vet-safe #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdcoffey merged 1 commit into from
May 29, 2026
Merged

[codex] Make indicator test helper vet-safe #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions testutils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,24 +88,14 @@ func decimalEquals(t *testing.T, expected float64, actual big.Decimal) {
assert.Equal(t, fmt.Sprintf("%.4f", expected), fmt.Sprintf("%.4f", actual.Float()))
}

func dump(indicator Indicator) (values []float64) {
func indicatorEquals(t *testing.T, expected []float64, indicator Indicator) {
precision := 4.0
m := math.Pow(10, precision)

defer func() {
recover()
}()

var index int
for {
values = append(values, math.Round(indicator.Calculate(index).Float()*m)/m)
index++
actualValues := make([]float64, len(expected))
for i := range expected {
actualValues[i] = math.Round(indicator.Calculate(i).Float()*m) / m
}

return
}

func indicatorEquals(t *testing.T, expected []float64, indicator Indicator) {
actualValues := dump(indicator)
assert.EqualValues(t, expected, actualValues)
}
Loading