Skip to content

[codex] Make indicator test helper vet-safe#66

Merged
sdcoffey merged 1 commit into
codex/harden-analysis-helpersfrom
codex/fix-vet-test-helper
May 29, 2026
Merged

[codex] Make indicator test helper vet-safe#66
sdcoffey merged 1 commit into
codex/harden-analysis-helpersfrom
codex/fix-vet-test-helper

Conversation

@sdcoffey

Copy link
Copy Markdown
Owner

Summary

  • replace the infinite-loop-plus-recover indicator test helper with a finite loop
  • preserve existing four-decimal rounding behavior
  • make modern go vet pass on the test package

Validation

  • GOCACHE=/private/tmp/techan-gocache mise x go@1.26.3 -- go test ./...
  • GOCACHE=/private/tmp/techan-gocache mise x go@1.26.3 -- go vet ./...

Stacked on #65.

@sdcoffey sdcoffey marked this pull request as ready for review May 29, 2026 15:28
@sdcoffey

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sdcoffey sdcoffey force-pushed the codex/harden-analysis-helpers branch from 0cae731 to 8a3d414 Compare May 29, 2026 15:42
@sdcoffey sdcoffey force-pushed the codex/fix-vet-test-helper branch from 76c9b9b to 3834d49 Compare May 29, 2026 15:42
@sdcoffey sdcoffey merged commit 3113eef into codex/harden-analysis-helpers May 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant