Skip to content

[codex] Harden analysis edge cases#65

Merged
sdcoffey merged 3 commits into
codex/document-indicator-warmupfrom
codex/harden-analysis-helpers
May 29, 2026
Merged

[codex] Harden analysis edge cases#65
sdcoffey merged 3 commits into
codex/document-indicator-warmupfrom
codex/harden-analysis-helpers

Conversation

@sdcoffey

Copy link
Copy Markdown
Owner

Summary

  • avoid divide-by-zero and panic paths in analysis helpers
  • return zero for empty or invalid period/average/buy-and-hold inputs
  • count profitable short trades correctly
  • add regression coverage for the newly guarded cases

Validation

  • GOCACHE=/private/tmp/techan-gocache mise x go@1.26.3 -- go test ./...

Stacked on #64.

@sdcoffey sdcoffey marked this pull request as ready for review May 29, 2026 15:28
@sdcoffey

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sdcoffey sdcoffey force-pushed the codex/document-indicator-warmup branch from a686623 to 9839f7f Compare May 29, 2026 15:42
@sdcoffey sdcoffey force-pushed the codex/harden-analysis-helpers branch from 0cae731 to 8a3d414 Compare May 29, 2026 15:42
[codex] Make indicator test helper vet-safe
@sdcoffey sdcoffey merged commit 09e9769 into codex/document-indicator-warmup May 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant