Skip to content

Filter node attrs without building an rx subgraph #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoOkuma merged 1 commit into from
Jul 1, 2026
Merged

Filter node attrs without building an rx subgraph #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/tracksdata/graph/_rustworkx_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,7 +950,6 @@ def _filter_nodes_by_attrs(
The IDs of the filtered nodes.
"""
rx_graph = self.rx_graph
node_map = None
# entire graph
attrs, time = _pop_time_eq(attrs)
selected_nodes = None
Expand All @@ -967,16 +966,15 @@ def _filter_nodes_by_attrs(
elif node_ids is not None:
selected_nodes = node_ids

if selected_nodes is not None:
# subgraph of selected nodes
rx_graph, node_map = rx_graph.subgraph_with_nodemap(selected_nodes)

_filter_func = _create_filter_func(attrs, self._node_attr_schemas())

if node_map is None:
if selected_nodes is None:
return list(rx_graph.filter_nodes(_filter_func))
else:
return [node_map[n] for n in rx_graph.filter_nodes(_filter_func)]

# evaluate the filter directly on the selected nodes' payloads;
# building an rx subgraph here would also copy every edge between
# the selected nodes just to discard them afterwards.
return [node_id for node_id in selected_nodes if _filter_func(rx_graph[node_id])]

def node_ids(self) -> list[int]:
"""
Expand Down
Loading