Filter node attrs without building an rx subgraph#316
Merged
Conversation
_filter_nodes_by_attrs constructed a full rustworkx subgraph (copying node payload references and every edge between the selected nodes) just to run filter_nodes on it, then mapped the indices back through the node map. Evaluating the filter function directly on the selected nodes' payload dicts avoids the O(nodes + edges) subgraph construction and the index round-trip (~1.7x faster on a 50k-node / 100k-edge graph when filtering half the nodes by attribute).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_filter_nodes_by_attrsbuilt a full rustworkx subgraph — copying every edge between the selected nodes — just to runfilter_nodeson the copy and map indices back.Evaluate the filter function directly on the selected nodes' payload dicts, skipping the O(nodes + edges) subgraph construction. ~1.7x faster on a 50k-node/100k-edge benchmark (13.8 ms → 8.0 ms).
Covered by existing filter tests.