Skip to content

proof(pointer): bind evidence template tag to app version #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rogu3bear merged 1 commit into from
May 12, 2026
Merged

proof(pointer): bind evidence template tag to app version #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/macos/Scripts/manual-release-evidence-template.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,14 @@ APP_BUNDLE_ID=$(/usr/libexec/PlistBuddy -c "Print :CFBundleIdentifier" "$INFO_PL
APP_VERSION=$(/usr/libexec/PlistBuddy -c "Print :CFBundleShortVersionString" "$INFO_PLIST")
APP_BUILD=$(/usr/libexec/PlistBuddy -c "Print :CFBundleVersion" "$INFO_PLIST")
APP_EXECUTABLE_SHA256="$(shasum -a 256 "$EXECUTABLE_PATH" | awk '{print $1}')"
EXPECTED_RELEASE_TAG="v$APP_VERSION"

if [[ "$RELEASE_TAG" != "$EXPECTED_RELEASE_TAG" ]]; then
echo "ERROR: RELEASE_TAG does not match mounted app version" >&2
echo "Release tag: $RELEASE_TAG" >&2

@kilo-code-bot kilo-code-bot Bot May 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: Inconsistent spacing in error message - colon followed by two spaces instead of one. Standardize for consistency.

Suggested change
echo "Release tag: $RELEASE_TAG" >&2
echo "Release tag: $RELEASE_TAG" >&2

echo "Expected tag: $EXPECTED_RELEASE_TAG" >&2
exit 2
fi

cat <<EOF
Release tag: $RELEASE_TAG
Expand Down
2 changes: 2 additions & 0 deletions apps/macos/Tests/PointerDesignerTests/IdentityTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,6 +812,8 @@ final class IdentityTests: XCTestCase {
XCTAssertTrue(template.contains("ERROR: RELEASE_TAG is required for artifact-bound manual release evidence"))
XCTAssertTrue(template.contains("make manual-release-evidence-template RELEASE_TAG="))
XCTAssertTrue(template.contains("v<app-version>"))
XCTAssertTrue(template.contains("EXPECTED_RELEASE_TAG=\"v$APP_VERSION\""))
XCTAssertTrue(template.contains("ERROR: RELEASE_TAG does not match mounted app version"))
XCTAssertTrue(template.contains("Commit:"))
XCTAssertTrue(template.contains("DMG SHA-256:"))
XCTAssertTrue(template.contains("App bundle ID:"))
Expand Down
Loading