Skip to content

proof(pointer): bind evidence template tag to app version#76

Merged
rogu3bear merged 1 commit into
mainfrom
proof/manual-evidence-tag-matches-app
May 12, 2026
Merged

proof(pointer): bind evidence template tag to app version#76
rogu3bear merged 1 commit into
mainfrom
proof/manual-evidence-tag-matches-app

Conversation

@rogu3bear

Copy link
Copy Markdown
Owner

Summary

  • make manual-release-evidence-template reject a RELEASE_TAG that does not match the mounted app version
  • preserve artifact binding at evidence-generation time instead of waiting for the later checker
  • pin the tag/version binding in IdentityTests

Verification

  • make -C apps/macos manual-release-evidence-template RELEASE_TAG=v0.0.0 exits 2 with the expected v1.0.0 tag message
  • swift test --package-path apps/macos --filter IdentityTests/testManualReleaseChecklistCoversHumanOnlyProof
  • git diff --check

Remaining blockers


if [[ "$RELEASE_TAG" != "$EXPECTED_RELEASE_TAG" ]]; then
echo "ERROR: RELEASE_TAG does not match mounted app version" >&2
echo "Release tag: $RELEASE_TAG" >&2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: Inconsistent spacing in error message - colon followed by two spaces instead of one. Standardize for consistency.

Suggested change
echo "Release tag: $RELEASE_TAG" >&2
echo "Release tag: $RELEASE_TAG" >&2

@kilo-code-bot

kilo-code-bot Bot commented May 12, 2026

Copy link
Copy Markdown

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
apps/macos/Scripts/manual-release-evidence-template.sh 93 Inconsistent spacing in error message - colon followed by two spaces instead of one
Other Observations (not in diff)

Issues found in unchanged code that cannot receive inline comments:

File Line Issue
apps/macos/Scripts/manual-release-evidence-template.sh N/A Consider adding validation for APP_VERSION to ensure it's not empty or invalid before using in EXPECTED_RELEASE_TAG

No rectification needed for CLAUDE.md and AGENTS.md as changes align with NORTH_STAR.md verification gates.

Files Reviewed (2 files)
  • apps/macos/Scripts/manual-release-evidence-template.sh - 1 issue
  • apps/macos/Tests/PointerDesignerTests/IdentityTests.swift - 0 issues

Reviewed by grok-code-fast-1:optimized:free · 159,875 tokens

@rogu3bear rogu3bear merged commit babda4b into main May 12, 2026
3 checks passed
@rogu3bear rogu3bear deleted the proof/manual-evidence-tag-matches-app branch May 12, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant